Skip to content

Commit fff40fd

Browse files
Merge pull request #230 from amandee27/fix/pagination-fix
Fix #228 pagination does not reset when updating search params
2 parents 236ad93 + 6e3eff9 commit fff40fd

File tree

2 files changed

+9
-3
lines changed

2 files changed

+9
-3
lines changed

src/app/(public)/repos/[language]/_components/sorter.tsx

+8-3
Original file line numberDiff line numberDiff line change
@@ -127,13 +127,17 @@ export function Sorter() {
127127
</Button>
128128
<div className="z-50 h-64 p-2 overflow-y-scroll shadow dropdown-content hidden group-hover:block bg-base-100 rounded-box w-60">
129129
<ul tabIndex={0} className="menu menu-vertical">
130-
{mainLanguages.sort(sortByName).map(language => (
130+
{mainLanguages.sort(sortByName).map(language => {
131+
const sp = new URLSearchParams(searchParams);
132+
sp.delete('p');
133+
return (
131134
<li key={language} onClick={handleClick}>
132-
<Link href={`/repos/${language.toLowerCase()}?${searchParams.toString()}`}>
135+
<Link href={`/repos/${language.toLowerCase()}?${sp.toString()}`}>
133136
{language}
134137
</Link>
135138
</li>
136-
))}
139+
);
140+
})}
137141
</ul>
138142
</div>
139143
</div>
@@ -149,6 +153,7 @@ export function Sorter() {
149153
<ul tabIndex={0} className="menu menu-vertical">
150154
{navigationItems.map((item, index) => {
151155
const sp = item.onSelect(new URLSearchParams(searchParams));
156+
sp.delete('p');
152157
if (item.name === SortTypes.BestMatch) {
153158
sp.delete('o');
154159
sp.delete('s');

src/app/(public)/repos/[language]/_components/stars-filter.tsx

+1
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ export function StarsFilter() {
4747
sp.set('startStars', startStars.toString());
4848
sp.set('endStars', endStars.toString());
4949
}
50+
sp.delete('p');
5051
router.push(`${pathname}?${sp.toString()}`);
5152
}
5253

0 commit comments

Comments
 (0)