ci: Add lint and test jobs (#367)

* ci: Add lint and test jobs

* Fix tests and lint

* Fix lint

* Fix tests

* Only one job

Author: amaury1093

.github/dependabot.yml

@@ -0,0 +1,9 @@
+version: 2
+updates:
+- package-ecosystem: npm
+  directory: "/"
+  schedule:
+    interval: weekly
+    time: "02:00"
+    timezone: Europe/Berlin
+  open-pull-requests-limit: 10

.github/workflows/pr.yml

@@ -0,0 +1,18 @@
+name: CI
+
+on:
+    push:
+        branches:
+            - master
+    pull_request:
+        branches:
+            - master
+
+jobs:
+    lint-and-test:
+        runs-on: ubuntu-latest
+        steps:
+            - uses: actions/checkout@v2
+            - run: yarn install
+            - run: yarn lint
+            - run: yarn test

.travis.yml

@@ -60,4 +60,4 @@
   "peerDependencies": {
     "electron": "^9.0.0 || ^10.0.0 || ^11.0.0 || ^12.0.0 || ^13.0.0 || ^14.0.0 || ^15.0.0 || ^16.0.0 || ^17.0.0 || ^18.0.0 || ^19.0.0 || ^20.0.0 || ^21.0.0"
   }
-}
+}

package.json

@@ -15,27 +15,33 @@ describe('Menubar', () => {
 		expect(mb!.app).toBeDefined();
 	});
 
-	it('should have property `positioner`', (done) => {
+	it('should have property `positioner`', () => {
 		expect(() => mb!.positioner as unknown).toThrow();
-		mb!.on('after-create-window', () => {
-			expect(mb!.positioner).toBeDefined();
-			done();
+		return new Promise<void>((resolve) => {
+			mb!.on('after-create-window', () => {
+				expect(mb!.positioner).toBeDefined();
+				resolve();
+			});
 		});
 	});
 
-	it('should have property `tray`', (done) => {
+	it('should have property `tray`', () => {
 		expect(() => mb!.tray).toThrow();
-		mb!.on('ready', () => {
-			expect(mb!.tray).toBeInstanceOf(Tray);
-			done();
+		return new Promise<void>((resolve) => {
+			mb!.on('ready', () => {
+				expect(mb!.tray).toBeInstanceOf(Tray);
+				resolve();
+			});
 		});
 	});
 
-	it('should have property `window`', (done) => {
+	it('should have property `window`', () => {
 		expect(mb!.window).toBeUndefined();
-		mb!.on('ready', () => {
-			expect(mb!.window).toBeInstanceOf(BrowserWindow);
-			done();
+		return new Promise<void>((resolve) => {
+			mb!.on('ready', () => {
+				expect(mb!.window).toBeInstanceOf(BrowserWindow);
+				resolve();
+			});
 		});
 	});
 });

src/Menubar.spec.ts

@@ -4,6 +4,7 @@ import { MOCK_APP_GETAPPPATH } from '../__mocks__/electron';
 import { cleanOptions } from './cleanOptions';
 
 const DEFAULT_OPTIONS = {
+	activateWithApp: true,
 	browserWindow: {
 		height: 400,
 		width: 400,

src/util/cleanOptions.spec.ts

@@ -1,9 +1,10 @@
 {
-  "extends": "./node_modules/@amaurym/tsconfig/tsconfig",
-  "compilerOptions": {
-    "declaration": true,
-    "module": "commonjs",
-    "outDir": "./lib",
-    "target": "es5"
-  }
+	"extends": "./node_modules/@amaurym/tsconfig/tsconfig",
+	"compilerOptions": {
+		"declaration": true,
+		"module": "commonjs",
+		"outDir": "./lib",
+		"skipLibCheck": true,
+		"target": "es5"
+	}
 }