-
-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example Fly mission uses hard-coding of mission points #121
Comments
Thanks for the issue. This has been requested several times actually and it would be a good thing to have. The only catch is that not all mission items are currently supported in DroneCore, so we won't be fully compatible. We would have to just ignore unsupported items and warn the user about it. |
@julianoes @shakthi-prashanth-m
The solution to this problem is NED based mission points - as per #100.
My take on this is that mission import should completely bypass whatever we do with the API. It would be something to add flexibility over the top of our existing API. So perhaps:
Yes I know it removes some of the "clean-ness" of the API, but if we don't do this then I personally as a user would be forced to write my own plugin to do this. |
@shakthi-prashanth-m So what does #121 (comment) add to this discussion? I still think we should implement #100 |
@hamishwillee, sorry which comment ? The link you referred says that you opened this on Oct 20, 2017! :-)
Yeah, I think this is useful too. So I added my question regarding NED mission for my understanding. |
@shakthi-prashanth-m I was asking about why you added #235 to this discussion. I've responded re NED missions. |
Yeah, because this issue was about complexity of user's effort in uploading mission with hard-coding waypoint alt, lon. As #235 deals this indirectly, I referenced it. |
Fly mission example uses hard-coding of waypoints. It is hard for someone to compute longitude, latitude, etc and use this example.
I prefer, we can make this example take QGC Mission plan as input; where one can plan missions using QGC and feed its path via command-line to this example.
We can parse QGC mission plan and pass mission items to DroneCore Mission plugin.
Make sense ?
Regards,
Shakthi
The text was updated successfully, but these errors were encountered: