Do not show invalid sketch filename warnings on reload

With this commit, any warnings about invalid sketch filenames are not
shown when the sketch is reloaded. This reloading happens whenever the
IDE window is focused, so re-logging warnings all the time isn't really
helpful, so this hides them.

Author: matthijskooijman

arduino-core/src/processing/app/SketchData.java

@@ -69,7 +69,7 @@ public int compare(SketchCode x, SketchCode y) {
     folder = new File(file.getParent());
     codeFolder = new File(folder, "code");
     dataFolder = new File(folder, "data");
-    codes = listSketchFiles();
+    codes = listSketchFiles(true);
   }
 
   static public File checkSketchFile(File file) {
@@ -104,7 +104,7 @@ static public File checkSketchFile(File file) {
    *         not.
    */
   public boolean reload() throws IOException {
-    List<SketchCode> reloaded = listSketchFiles();
+    List<SketchCode> reloaded = listSketchFiles(false);
     if (!reloaded.equals(codes)) {
       codes = reloaded;
       return true;
@@ -121,7 +121,7 @@ public boolean reload() throws IOException {
    * @param showWarnings
    *          When true, any invalid filenames will show a warning.
    */
-  private List<SketchCode> listSketchFiles() throws IOException {
+  private List<SketchCode> listSketchFiles(boolean showWarnings) throws IOException {
     // get list of files in the sketch folder
     String filenames[] = folder.list();
     if (filenames == null) {
@@ -147,7 +147,7 @@ private List<SketchCode> listSketchFiles() throws IOException {
         // filenames. [0116]
         if (BaseNoGui.isSanitaryName(pieces[0])) {
           result.add(new SketchCode(file, file.equals(primaryFile)));
-        } else {
+        } else if (showWarnings) {
           System.err.println(I18n.format("File name {0} is invalid: ignored", filename));
         }
       }