Skip to content

Commit 0947f2e

Browse files
matthiaskrgrmatthiaskrgr
authored
Rollup merge of rust-lang#122839 - compiler-errors:predicate-polarity, r=lcnr
Split out `PredicatePolarity` from `ImplPolarity` Because having to deal with a third `Reservation` level in all the trait solver code is kind of weird. r? ``@lcnr`` or ``@oli-obk``
2 parents 75fa268 + dae3c43 commit 0947f2e

File tree

35 files changed

+158
-115
lines changed

35 files changed

+158
-115
lines changed

‎compiler/rustc_borrowck/src/type_check/canonical.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ impl<'a, 'tcx> TypeChecker<'a, 'tcx> {
8282
) {
8383
self.prove_predicate(
8484
ty::Binder::dummy(ty::PredicateKind::Clause(ty::ClauseKind::Trait(
85-
ty::TraitPredicate { trait_ref, polarity: ty::ImplPolarity::Positive },
85+
ty::TraitPredicate { trait_ref, polarity: ty::PredicatePolarity::Positive },
8686
))),
8787
locations,
8888
category,

‎compiler/rustc_hir_analysis/src/astconv/bounds.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -132,16 +132,16 @@ impl<'tcx> dyn AstConv<'tcx> + '_ {
132132
hir::GenericBound::Trait(poly_trait_ref, modifier) => {
133133
let (constness, polarity) = match modifier {
134134
hir::TraitBoundModifier::Const => {
135-
(ty::BoundConstness::Const, ty::ImplPolarity::Positive)
135+
(ty::BoundConstness::Const, ty::PredicatePolarity::Positive)
136136
}
137137
hir::TraitBoundModifier::MaybeConst => {
138-
(ty::BoundConstness::ConstIfConst, ty::ImplPolarity::Positive)
138+
(ty::BoundConstness::ConstIfConst, ty::PredicatePolarity::Positive)
139139
}
140140
hir::TraitBoundModifier::None => {
141-
(ty::BoundConstness::NotConst, ty::ImplPolarity::Positive)
141+
(ty::BoundConstness::NotConst, ty::PredicatePolarity::Positive)
142142
}
143143
hir::TraitBoundModifier::Negative => {
144-
(ty::BoundConstness::NotConst, ty::ImplPolarity::Negative)
144+
(ty::BoundConstness::NotConst, ty::PredicatePolarity::Negative)
145145
}
146146
hir::TraitBoundModifier::Maybe => continue,
147147
};

‎compiler/rustc_hir_analysis/src/astconv/mod.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -645,7 +645,7 @@ impl<'tcx> dyn AstConv<'tcx> + '_ {
645645
trait_ref: &hir::TraitRef<'tcx>,
646646
span: Span,
647647
constness: ty::BoundConstness,
648-
polarity: ty::ImplPolarity,
648+
polarity: ty::PredicatePolarity,
649649
self_ty: Ty<'tcx>,
650650
bounds: &mut Bounds<'tcx>,
651651
only_self_bounds: OnlySelfBounds,
@@ -682,7 +682,7 @@ impl<'tcx> dyn AstConv<'tcx> + '_ {
682682
// Don't register additional associated type bounds for negative bounds,
683683
// since we should have emitten an error for them earlier, and they will
684684
// not be well-formed!
685-
if polarity == ty::ImplPolarity::Negative {
685+
if polarity != ty::PredicatePolarity::Positive {
686686
assert!(
687687
self.tcx().dcx().has_errors().is_some(),
688688
"negative trait bounds should not have bindings",

‎compiler/rustc_hir_analysis/src/astconv/object_safety.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ impl<'tcx> dyn AstConv<'tcx> + '_ {
4141
&trait_bound.trait_ref,
4242
trait_bound.span,
4343
ty::BoundConstness::NotConst,
44-
ty::ImplPolarity::Positive,
44+
ty::PredicatePolarity::Positive,
4545
dummy_self,
4646
&mut bounds,
4747
// True so we don't populate `bounds` with associated type bounds, even
@@ -58,7 +58,7 @@ impl<'tcx> dyn AstConv<'tcx> + '_ {
5858
let bound_pred = pred.kind();
5959
match bound_pred.skip_binder() {
6060
ty::ClauseKind::Trait(trait_pred) => {
61-
assert_eq!(trait_pred.polarity, ty::ImplPolarity::Positive);
61+
assert_eq!(trait_pred.polarity, ty::PredicatePolarity::Positive);
6262
trait_bounds.push((bound_pred.rebind(trait_pred.trait_ref), span));
6363
}
6464
ty::ClauseKind::Projection(proj) => {

‎compiler/rustc_hir_analysis/src/bounds.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ impl<'tcx> Bounds<'tcx> {
4242
tcx: TyCtxt<'tcx>,
4343
trait_ref: ty::PolyTraitRef<'tcx>,
4444
span: Span,
45-
polarity: ty::ImplPolarity,
45+
polarity: ty::PredicatePolarity,
4646
) {
4747
self.push_trait_bound_inner(tcx, trait_ref, span, polarity);
4848
}
@@ -52,7 +52,7 @@ impl<'tcx> Bounds<'tcx> {
5252
tcx: TyCtxt<'tcx>,
5353
trait_ref: ty::PolyTraitRef<'tcx>,
5454
span: Span,
55-
polarity: ty::ImplPolarity,
55+
polarity: ty::PredicatePolarity,
5656
) {
5757
self.clauses.push((
5858
trait_ref

‎compiler/rustc_hir_analysis/src/check/wfcheck.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1322,7 +1322,7 @@ fn check_impl<'tcx>(
13221322
trait_ref,
13231323
);
13241324
let trait_pred =
1325-
ty::TraitPredicate { trait_ref, polarity: ty::ImplPolarity::Positive };
1325+
ty::TraitPredicate { trait_ref, polarity: ty::PredicatePolarity::Positive };
13261326
let mut obligations = traits::wf::trait_obligations(
13271327
wfcx.infcx,
13281328
wfcx.param_env,

‎compiler/rustc_hir_analysis/src/coherence/builtin.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -551,7 +551,7 @@ fn infringing_fields_error(
551551
}
552552
if let ty::PredicateKind::Clause(ty::ClauseKind::Trait(ty::TraitPredicate {
553553
trait_ref,
554-
polarity: ty::ImplPolarity::Positive,
554+
polarity: ty::PredicatePolarity::Positive,
555555
..
556556
})) = error_predicate.kind().skip_binder()
557557
{

‎compiler/rustc_hir_analysis/src/collect/predicates_of.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -624,7 +624,7 @@ pub(super) fn implied_predicates_with_filter(
624624
for &(pred, span) in implied_bounds {
625625
debug!("superbound: {:?}", pred);
626626
if let ty::ClauseKind::Trait(bound) = pred.kind().skip_binder()
627-
&& bound.polarity == ty::ImplPolarity::Positive
627+
&& bound.polarity == ty::PredicatePolarity::Positive
628628
{
629629
tcx.at(span).super_predicates_of(bound.def_id());
630630
}
@@ -634,7 +634,7 @@ pub(super) fn implied_predicates_with_filter(
634634
for &(pred, span) in implied_bounds {
635635
debug!("superbound: {:?}", pred);
636636
if let ty::ClauseKind::Trait(bound) = pred.kind().skip_binder()
637-
&& bound.polarity == ty::ImplPolarity::Positive
637+
&& bound.polarity == ty::PredicatePolarity::Positive
638638
{
639639
tcx.at(span).implied_predicates_of(bound.def_id());
640640
}

‎compiler/rustc_hir_typeck/src/expr.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3100,7 +3100,7 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> {
31003100
cause.clone().derived_cause(
31013101
ty::Binder::dummy(ty::TraitPredicate {
31023102
trait_ref: impl_trait_ref,
3103-
polarity: ty::ImplPolarity::Positive,
3103+
polarity: ty::PredicatePolarity::Positive,
31043104
}),
31053105
|derived| {
31063106
traits::ImplDerivedObligation(Box::new(

‎compiler/rustc_hir_typeck/src/method/suggest.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -875,7 +875,7 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> {
875875
match pred.kind().skip_binder() {
876876
ty::PredicateKind::Clause(ty::ClauseKind::Trait(pred)) => {
877877
Some(pred.def_id()) == self.tcx.lang_items().sized_trait()
878-
&& pred.polarity == ty::ImplPolarity::Positive
878+
&& pred.polarity == ty::PredicatePolarity::Positive
879879
}
880880
_ => false,
881881
}
@@ -3367,7 +3367,7 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> {
33673367
"inherent impls can't be candidates, only trait impls can be",
33683368
)
33693369
})
3370-
.filter(|header| header.polarity == ty::ImplPolarity::Negative)
3370+
.filter(|header| header.polarity != ty::ImplPolarity::Positive)
33713371
.any(|header| {
33723372
let imp = header.trait_ref.instantiate_identity();
33733373
let imp_simp =

‎compiler/rustc_infer/src/infer/error_reporting/note_and_explain.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -306,7 +306,7 @@ impl<T> Trait<T> for X {
306306
.any(|(pred, _span)| match pred.kind().skip_binder() {
307307
ty::ClauseKind::Trait(trait_predicate)
308308
if trait_predicate.polarity
309-
== ty::ImplPolarity::Positive =>
309+
== ty::PredicatePolarity::Positive =>
310310
{
311311
trait_predicate.def_id() == def_id
312312
}
@@ -420,7 +420,7 @@ impl<T> Trait<T> for X {
420420
else {
421421
continue;
422422
};
423-
if trait_predicate.polarity != ty::ImplPolarity::Positive {
423+
if trait_predicate.polarity != ty::PredicatePolarity::Positive {
424424
continue;
425425
}
426426
let def_id = trait_predicate.def_id();

‎compiler/rustc_infer/src/traits/mod.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,7 @@ impl<'tcx> FulfillmentError<'tcx> {
209209
}
210210

211211
impl<'tcx> PolyTraitObligation<'tcx> {
212-
pub fn polarity(&self) -> ty::ImplPolarity {
212+
pub fn polarity(&self) -> ty::PredicatePolarity {
213213
self.predicate.skip_binder().polarity
214214
}
215215

‎compiler/rustc_infer/src/traits/util.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -270,7 +270,7 @@ impl<'tcx, O: Elaboratable<'tcx>> Elaborator<'tcx, O> {
270270
match bound_clause.skip_binder() {
271271
ty::ClauseKind::Trait(data) => {
272272
// Negative trait bounds do not imply any supertrait bounds
273-
if data.polarity == ty::ImplPolarity::Negative {
273+
if data.polarity != ty::PredicatePolarity::Positive {
274274
return;
275275
}
276276
// Get predicates implied by the trait, or only super predicates if we only care about self predicates.

‎compiler/rustc_lint/src/builtin.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -726,7 +726,7 @@ fn type_implements_negative_copy_modulo_regions<'tcx>(
726726
param_env: ty::ParamEnv<'tcx>,
727727
) -> bool {
728728
let trait_ref = ty::TraitRef::new(tcx, tcx.require_lang_item(hir::LangItem::Copy, None), [ty]);
729-
let pred = ty::TraitPredicate { trait_ref, polarity: ty::ImplPolarity::Negative };
729+
let pred = ty::TraitPredicate { trait_ref, polarity: ty::PredicatePolarity::Negative };
730730
let obligation = traits::Obligation {
731731
cause: traits::ObligationCause::dummy(),
732732
param_env,

‎compiler/rustc_middle/src/ty/context.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@ use crate::traits::solve::{
2727
use crate::ty::{
2828
self, AdtDef, AdtDefData, AdtKind, Binder, Clause, Const, ConstData, GenericParamDefKind,
2929
ImplPolarity, List, ParamConst, ParamTy, PolyExistentialPredicate, PolyFnSig, Predicate,
30-
PredicateKind, Region, RegionKind, ReprOptions, TraitObjectVisitor, Ty, TyKind, TyVid,
31-
TypeVisitable, Visibility,
30+
PredicateKind, PredicatePolarity, Region, RegionKind, ReprOptions, TraitObjectVisitor, Ty,
31+
TyKind, TyVid, TypeVisitable, Visibility,
3232
};
3333
use crate::ty::{GenericArg, GenericArgs, GenericArgsRef};
3434
use rustc_ast::{self as ast, attr};
@@ -1526,7 +1526,7 @@ macro_rules! nop_slice_lift {
15261526
nop_slice_lift! {ty::ValTree<'a> => ty::ValTree<'tcx>}
15271527

15281528
TrivialLiftImpls! {
1529-
ImplPolarity, Promoted
1529+
ImplPolarity, PredicatePolarity, Promoted
15301530
}
15311531

15321532
macro_rules! sty_debug_print {
@@ -1833,7 +1833,7 @@ impl<'tcx> TyCtxt<'tcx> {
18331833
return false;
18341834
};
18351835
trait_predicate.trait_ref.def_id == future_trait
1836-
&& trait_predicate.polarity == ImplPolarity::Positive
1836+
&& trait_predicate.polarity == PredicatePolarity::Positive
18371837
})
18381838
}
18391839

‎compiler/rustc_middle/src/ty/error.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ impl<T> ExpectedFound<T> {
3232
pub enum TypeError<'tcx> {
3333
Mismatch,
3434
ConstnessMismatch(ExpectedFound<ty::BoundConstness>),
35-
PolarityMismatch(ExpectedFound<ty::ImplPolarity>),
35+
PolarityMismatch(ExpectedFound<ty::PredicatePolarity>),
3636
UnsafetyMismatch(ExpectedFound<hir::Unsafety>),
3737
AbiMismatch(ExpectedFound<abi::Abi>),
3838
Mutability,

‎compiler/rustc_middle/src/ty/mod.rs

Lines changed: 27 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -280,23 +280,43 @@ pub enum ImplPolarity {
280280
Reservation,
281281
}
282282

283-
impl ImplPolarity {
283+
impl fmt::Display for ImplPolarity {
284+
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
285+
match self {
286+
Self::Positive => f.write_str("positive"),
287+
Self::Negative => f.write_str("negative"),
288+
Self::Reservation => f.write_str("reservation"),
289+
}
290+
}
291+
}
292+
293+
/// Polarity for a trait predicate. May either be negative or positive.
294+
/// Distinguished from [`ImplPolarity`] since we never compute goals with
295+
/// "reservation" level.
296+
#[derive(Copy, Clone, PartialEq, Eq, Hash, TyEncodable, TyDecodable, HashStable, Debug)]
297+
#[derive(TypeFoldable, TypeVisitable)]
298+
pub enum PredicatePolarity {
299+
/// `Type: Trait`
300+
Positive,
301+
/// `Type: !Trait`
302+
Negative,
303+
}
304+
305+
impl PredicatePolarity {
284306
/// Flips polarity by turning `Positive` into `Negative` and `Negative` into `Positive`.
285-
pub fn flip(&self) -> Option<ImplPolarity> {
307+
pub fn flip(&self) -> PredicatePolarity {
286308
match self {
287-
ImplPolarity::Positive => Some(ImplPolarity::Negative),
288-
ImplPolarity::Negative => Some(ImplPolarity::Positive),
289-
ImplPolarity::Reservation => None,
309+
PredicatePolarity::Positive => PredicatePolarity::Negative,
310+
PredicatePolarity::Negative => PredicatePolarity::Positive,
290311
}
291312
}
292313
}
293314

294-
impl fmt::Display for ImplPolarity {
315+
impl fmt::Display for PredicatePolarity {
295316
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
296317
match self {
297318
Self::Positive => f.write_str("positive"),
298319
Self::Negative => f.write_str("negative"),
299-
Self::Reservation => f.write_str("reservation"),
300320
}
301321
}
302322
}

‎compiler/rustc_middle/src/ty/predicate.rs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ use std::cmp::Ordering;
1111
use crate::ty::visit::TypeVisitableExt;
1212
use crate::ty::{
1313
self, AliasTy, Binder, DebruijnIndex, DebugWithInfcx, EarlyBinder, GenericArg, GenericArgs,
14-
GenericArgsRef, ImplPolarity, Term, Ty, TyCtxt, TypeFlags, WithCachedTypeInfo,
14+
GenericArgsRef, PredicatePolarity, Term, Ty, TyCtxt, TypeFlags, WithCachedTypeInfo,
1515
};
1616

1717
pub type ClauseKind<'tcx> = IrClauseKind<TyCtxt<'tcx>>;
@@ -70,7 +70,7 @@ impl<'tcx> Predicate<'tcx> {
7070
polarity,
7171
})) => Some(PredicateKind::Clause(ClauseKind::Trait(TraitPredicate {
7272
trait_ref,
73-
polarity: polarity.flip()?,
73+
polarity: polarity.flip(),
7474
}))),
7575

7676
_ => None,
@@ -663,7 +663,7 @@ pub struct TraitPredicate<'tcx> {
663663
/// exist via a series of predicates.)
664664
///
665665
/// If polarity is Reserved: that's a bug.
666-
pub polarity: ImplPolarity,
666+
pub polarity: PredicatePolarity,
667667
}
668668

669669
pub type PolyTraitPredicate<'tcx> = ty::Binder<'tcx, TraitPredicate<'tcx>>;
@@ -693,7 +693,7 @@ impl<'tcx> PolyTraitPredicate<'tcx> {
693693
}
694694

695695
#[inline]
696-
pub fn polarity(self) -> ImplPolarity {
696+
pub fn polarity(self) -> PredicatePolarity {
697697
self.skip_binder().polarity
698698
}
699699
}
@@ -907,7 +907,7 @@ impl<'tcx> ToPredicate<'tcx> for TraitRef<'tcx> {
907907
impl<'tcx> ToPredicate<'tcx, TraitPredicate<'tcx>> for TraitRef<'tcx> {
908908
#[inline(always)]
909909
fn to_predicate(self, _tcx: TyCtxt<'tcx>) -> TraitPredicate<'tcx> {
910-
TraitPredicate { trait_ref: self, polarity: ImplPolarity::Positive }
910+
TraitPredicate { trait_ref: self, polarity: PredicatePolarity::Positive }
911911
}
912912
}
913913

@@ -940,7 +940,7 @@ impl<'tcx> ToPredicate<'tcx, PolyTraitPredicate<'tcx>> for Binder<'tcx, TraitRef
940940
fn to_predicate(self, _: TyCtxt<'tcx>) -> PolyTraitPredicate<'tcx> {
941941
self.map_bound(|trait_ref| TraitPredicate {
942942
trait_ref,
943-
polarity: ty::ImplPolarity::Positive,
943+
polarity: ty::PredicatePolarity::Positive,
944944
})
945945
}
946946
}

0 commit comments

Comments
 (0)