Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Simple upload images and files like in django-ckeditor #4

Open
shtalinberg opened this issue Jul 4, 2024 · 6 comments

Comments

@shtalinberg
Copy link

Usually clients wants to upload file and generate source code for uploaded images via editor

@matthiask
Copy link
Owner

Thanks for the issue. I don't think I'm going to add an image upload because there's so much infrastructure work to do for image handling, and also, generally, I have documented my views on this here:
https://github.com/matthiask/django-prose-editor?tab=readme-ov-file#about-rich-text-editors

@shtalinberg
Copy link
Author

but it works in django-prose
maybe they won't mind sharing a ready-to-use solution?

@matthiask
Copy link
Owner

django-prose builds on Trix (https://trix-editor.org/), that's a completely different foundation to build an editor on, so we couldn't just use it 1:1.

Still interesting to look at their implementation of the upload view. It seems there's no media library, it's just attachments without a way to browse the uploads later. That seems quite straightforward to implement.

I'm still thinking about ways to extend the editor in project-specific environments, I'd want to solve that first.

@jedie
Copy link

jedie commented Sep 5, 2024

What's about: https://prosemirror.net/examples/upload/ ?

@matthiask
Copy link
Owner

Yes, that would probably be the way to implement it.

@matthiask
Copy link
Owner

matthiask commented Jan 17, 2025

The prose editor bundle still doesn't contain the Image extension but it would be relatively easy to add it; this wouldn't help too much because we still wouldn't have a way to actually upload images. The FileHandler extension is a pro extension unfortunately so I cannot bundle it, and it wouldn't add the server part either for that matter.

At least the client side would be less work than it would have been before 0.10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants