Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unminified Editor.js File #22

Open
josephetareh opened this issue Jan 9, 2025 · 1 comment
Open

Unminified Editor.js File #22

josephetareh opened this issue Jan 9, 2025 · 1 comment

Comments

@josephetareh
Copy link

I love this library and it was really easy to get it going but while I understand the need to have minified JS files for speed, having un-minified versions of the editor.js file would make it much easier to create truly customizable. Can this be provided in the near future? Thanks.

@matthiask
Copy link
Owner

Thank you! I'm glad to hear it.

I'm not 100% sure I understand which advantages you'd get compared to reading the code since the code will still be processed by the bundler. A >800kb JS file isn't exactly readable after all :-)

You could try commenting out the minify:true line in esbuild.mjs and running yarn prod once to recreate the unminified but bundled JS file. I'm also attaching it here:

editor.js.txt

I prefer reading the source code in https://github.com/matthiask/django-prose-editor/tree/main/src or reading the official ProseMirror docs https://prosemirror.net/docs/ or even the ProseMirror code itself when working on an editor. How would having the full unminified but bundled JS be potentially better than this? I'm not against including the bundled JS also, but I'd like to understand why you'd want that instead of the alternatives since it still is a really large blob. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants