Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: Remove EVM emulator gas stipend #82

Merged
merged 4 commits into from
Jan 27, 2025

Conversation

slowli
Copy link
Contributor

@slowli slowli commented Jan 24, 2025

What ❔

Removes the EVM emulator gas stipend and replaces it with a memory stipend.

Why ❔

Aligns with the changes in the legacy VM.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Documentation comments have been added / updated.
  • Code has been formatted via cargo fmt and cargo clippy.

@slowli slowli marked this pull request as ready for review January 24, 2025 12:23
@slowli slowli requested a review from joonazan as a code owner January 24, 2025 12:23
@slowli
Copy link
Contributor Author

slowli commented Jan 24, 2025

  • I've tested this code on multivm unit tests (with the legacy VM revision updated, of course), so there's some insurance that it works correctly. OTOH, I had to remove the stipend test because it no longer made sense. Would it be possible to replace it somehow?
  • Breaking changes could theoretically be removed / moved to another PR.

Copy link
Contributor

@joonazan joonazan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good apart from a few little things.
Removing the test is fine because the system replacing stipends isn't nearly as dangerous.

crates/vm2/src/single_instruction_test/callframe.rs Outdated Show resolved Hide resolved
crates/vm2/src/tracing.rs Outdated Show resolved Hide resolved
@slowli slowli force-pushed the aov-pla-1084-remove-evm-gas-stipend branch from c168fdb to 194763b Compare January 27, 2025 10:56
@slowli slowli requested a review from joonazan January 27, 2025 11:28
@slowli slowli merged commit bf63339 into master Jan 27, 2025
9 checks passed
@slowli slowli deleted the aov-pla-1084-remove-evm-gas-stipend branch January 27, 2025 14:18
joonazan pushed a commit that referenced this pull request Jan 29, 2025
🤖 I have created a release *beep* *boop*
---


## [0.3.0](v0.2.1...v0.3.0)
(2025-01-27)


### ⚠ BREAKING CHANGES

* Remove EVM emulator gas stipend
([#82](#82))
* Revise VM storage interface
([#73](#73))

### Features

* Allow customizing precompiles logic
([#79](#79))
([3841f5a](3841f5a))
* allow tracers to stop/suspend execution
([#78](#78))
([457d8a7](457d8a7))
* expose storage to tracers
([#77](#77))
([df5bec3](df5bec3))


### Bug Fixes

* **ci:** Update github-hosted runner label
([#80](#80))
([70a6e30](70a6e30))
* failing far call tracing
([#81](#81))
([5df8c33](5df8c33))
* Remove EVM emulator gas stipend
([#82](#82))
([bf63339](bf63339))
* Revise VM storage interface
([#73](#73))
([a233d44](a233d44))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: zksync-era-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants