Skip to content

Implicit handling of verification room events and consequences #1341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BillCarsonFr opened this issue Jan 11, 2023 · 0 comments · Fixed by #1342
Closed

Implicit handling of verification room events and consequences #1341

BillCarsonFr opened this issue Jan 11, 2023 · 0 comments · Fixed by #1342

Comments

@BillCarsonFr
Copy link
Member

Currently verification events are handled implicitely by the rust crate:
When decryption is called, if the decrypted event is a verification event it is then passed to the verification machine

Problem

If the client calls multiple decryptions it will have for effect that verifications events will be replayed, causing various failures on verifications.
One could say that client should avoid to retry decryption, but it could happen and nothing from API let you forsee the potential impact.

Also there is some asymmetry, where clear room verification events has to be passed manually to the olmMachine but not encrypted one

Proposed Solution

As per this comment, it would be better to have a single method that you need to call explicitly for every room verification event

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant