Skip to content

Commit c86c842

Browse files
committed
sdk-ui: fix pinned events benchmark
1 parent c37c8c5 commit c86c842

File tree

1 file changed

+10
-6
lines changed

1 file changed

+10
-6
lines changed

benchmarks/benches/room_bench.rs

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
use std::time::Duration;
1+
use std::{sync::Arc, time::Duration};
22

33
use criterion::{criterion_group, criterion_main, BenchmarkId, Criterion, Throughput};
44
use matrix_sdk::{
@@ -157,7 +157,6 @@ pub fn load_pinned_events_benchmark(c: &mut Criterion) {
157157
.respond_with(move |r: &Request| {
158158
let segments: Vec<&str> = r.url.path_segments().expect("Invalid path").collect();
159159
let event_id_str = segments[6];
160-
// let f = EventFactory::new().room(&room_id)
161160
let event_id = EventId::parse(event_id_str).expect("Invalid event id in response");
162161
let event = f
163162
.text_msg(format!("Message {event_id_str}"))
@@ -170,9 +169,6 @@ pub fn load_pinned_events_benchmark(c: &mut Criterion) {
170169
})
171170
.mount(&server),
172171
);
173-
// runtime.block_on(server.reset());
174-
175-
client.event_cache().subscribe().unwrap();
176172

177173
let room = client.get_room(&room_id).expect("Room not found");
178174
assert!(!room.pinned_event_ids().is_empty());
@@ -184,6 +180,15 @@ pub fn load_pinned_events_benchmark(c: &mut Criterion) {
184180
group.throughput(Throughput::Elements(count as u64));
185181
group.sample_size(10);
186182

183+
let client = Arc::new(client);
184+
185+
{
186+
let client = client.clone();
187+
runtime.spawn_blocking(move || {
188+
client.event_cache().subscribe().unwrap();
189+
});
190+
}
191+
187192
group.bench_function(BenchmarkId::new("load_pinned_events", name), |b| {
188193
b.to_async(&runtime).iter(|| async {
189194
assert!(!room.pinned_event_ids().is_empty());
@@ -207,7 +212,6 @@ pub fn load_pinned_events_benchmark(c: &mut Criterion) {
207212
{
208213
let _guard = runtime.enter();
209214
runtime.block_on(server.reset());
210-
drop(client);
211215
drop(server);
212216
}
213217

0 commit comments

Comments
 (0)