fix type hint for RecordBuilder property

Author: sgiehl

core/ArchiveProcessor/RecordBuilder.php

@@ -30,7 +30,7 @@ abstract class RecordBuilder
     protected $maxRowsInSubtable;
 
     /**
-     * @var string|null
+     * @var string|int|null
      */
     protected $columnToSortByBeforeTruncation;
 

phpstan-baseline.neon

@@ -3438,11 +3438,6 @@ parameters:
 			count: 1
 			path: plugins/BulkTracking/Tracker/Handler.php
 
-		-
-			message: "#^Property Piwik\\\\ArchiveProcessor\\\\RecordBuilder\\:\\:\\$columnToSortByBeforeTruncation \\(string\\|null\\) does not accept int\\.$#"
-			count: 1
-			path: plugins/Contents/RecordBuilders/ContentRecords.php
-
 		-
 			message: "#^Result of && is always false\\.$#"
 			count: 1
@@ -3978,11 +3973,6 @@ parameters:
 			count: 1
 			path: plugins/CustomDimensions/RecordBuilders/CustomDimension.php
 
-		-
-			message: "#^Property Piwik\\\\ArchiveProcessor\\\\RecordBuilder\\:\\:\\$columnToSortByBeforeTruncation \\(string\\|null\\) does not accept int\\.$#"
-			count: 1
-			path: plugins/CustomDimensions/RecordBuilders/CustomDimension.php
-
 		-
 			message: "#^Variable \\$value in isset\\(\\) always exists and is not nullable\\.$#"
 			count: 1
@@ -4023,11 +4013,6 @@ parameters:
 			count: 1
 			path: plugins/Dashboard/Model.php
 
-		-
-			message: "#^Property Piwik\\\\ArchiveProcessor\\\\RecordBuilder\\:\\:\\$columnToSortByBeforeTruncation \\(string\\|null\\) does not accept int\\.$#"
-			count: 1
-			path: plugins/DevicePlugins/RecordBuilders/DevicePlugins.php
-
 		-
 			message: "#^Call to an undefined method Piwik\\\\DataTable\\\\DataTableInterface\\:\\:getDataTables\\(\\)\\.$#"
 			count: 1
@@ -4063,11 +4048,6 @@ parameters:
 			count: 1
 			path: plugins/DevicesDetection/Columns/Os.php
 
-		-
-			message: "#^Property Piwik\\\\ArchiveProcessor\\\\RecordBuilder\\:\\:\\$columnToSortByBeforeTruncation \\(string\\|null\\) does not accept int\\.$#"
-			count: 1
-			path: plugins/DevicesDetection/RecordBuilders/Base.php
-
 		-
 			message: "#^Variable \\$label in empty\\(\\) always exists and is not falsy\\.$#"
 			count: 1
@@ -4268,11 +4248,6 @@ parameters:
 			count: 1
 			path: plugins/Events/Columns/TotalEvents.php
 
-		-
-			message: "#^Property Piwik\\\\ArchiveProcessor\\\\RecordBuilder\\:\\:\\$columnToSortByBeforeTruncation \\(string\\|null\\) does not accept int\\.$#"
-			count: 1
-			path: plugins/Events/RecordBuilders/EventReports.php
-
 		-
 			message: "#^Property Piwik\\\\Plugin\\\\Report\\:\\:\\$processedMetrics \\(array\\) does not accept false\\.$#"
 			count: 1
@@ -5248,11 +5223,6 @@ parameters:
 			count: 1
 			path: plugins/Referrers/DataTable/Filter/SetGetReferrerTypeSubtables.php
 
-		-
-			message: "#^Property Piwik\\\\ArchiveProcessor\\\\RecordBuilder\\:\\:\\$columnToSortByBeforeTruncation \\(string\\|null\\) does not accept int\\.$#"
-			count: 1
-			path: plugins/Referrers/RecordBuilders/Referrers.php
-
 		-
 			message: "#^Method Piwik\\\\Plugins\\\\Referrers\\\\SearchEngine\\:\\:getBackLinkFromUrlAndKeyword\\(\\) should return string but returns false\\.$#"
 			count: 1
@@ -5268,16 +5238,6 @@ parameters:
 			count: 1
 			path: plugins/Referrers/functions.php
 
-		-
-			message: "#^Property Piwik\\\\ArchiveProcessor\\\\RecordBuilder\\:\\:\\$columnToSortByBeforeTruncation \\(string\\|null\\) does not accept int\\.$#"
-			count: 1
-			path: plugins/Resolution/RecordBuilders/Configuration.php
-
-		-
-			message: "#^Property Piwik\\\\ArchiveProcessor\\\\RecordBuilder\\:\\:\\$columnToSortByBeforeTruncation \\(string\\|null\\) does not accept int\\.$#"
-			count: 1
-			path: plugins/Resolution/RecordBuilders/Resolution.php
-
 		-
 			message: "#^Parameter \\#1 \\$data of function simplexml_load_string expects string, bool given\\.$#"
 			count: 1
@@ -5613,11 +5573,6 @@ parameters:
 			count: 1
 			path: plugins/UserCountry/LocationProvider.php
 
-		-
-			message: "#^Property Piwik\\\\ArchiveProcessor\\\\RecordBuilder\\:\\:\\$columnToSortByBeforeTruncation \\(string\\|null\\) does not accept int\\.$#"
-			count: 1
-			path: plugins/UserCountry/RecordBuilders/Locations.php
-
 		-
 			message: "#^Parameter \\#6 \\$willDelete of method Piwik\\\\DataAccess\\\\RawLogDao\\:\\:forAllLogs\\(\\) expects string, false given\\.$#"
 			count: 1
@@ -5643,11 +5598,6 @@ parameters:
 			count: 1
 			path: plugins/UserId/RecordBuilders/Users.php
 
-		-
-			message: "#^Property Piwik\\\\ArchiveProcessor\\\\RecordBuilder\\:\\:\\$columnToSortByBeforeTruncation \\(string\\|null\\) does not accept int\\.$#"
-			count: 1
-			path: plugins/UserId/RecordBuilders/Users.php
-
 		-
 			message: "#^Property Piwik\\\\ViewDataTable\\\\RequestConfig\\:\\:\\$filter_excludelowpop_value \\(Closure\\|string\\) does not accept 2\\.$#"
 			count: 1
@@ -5658,11 +5608,6 @@ parameters:
 			count: 1
 			path: plugins/UserLanguage/RecordBuilders/Languages.php
 
-		-
-			message: "#^Property Piwik\\\\ArchiveProcessor\\\\RecordBuilder\\:\\:\\$columnToSortByBeforeTruncation \\(string\\|null\\) does not accept int\\.$#"
-			count: 1
-			path: plugins/UserLanguage/RecordBuilders/Languages.php
-
 		-
 			message: "#^Default value of the parameter \\#5 \\$expireHours \\(int\\) of method Piwik\\\\Plugins\\\\UsersManager\\\\API\\:\\:createAppSpecificTokenAuth\\(\\) is incompatible with type string\\.$#"
 			count: 1