Fix: The themePreferenceChange event should have changed values

1aron · 1aron · commit 3aba1fdb6861 · 2024-06-09T08:46:56.000+08:00
diff --git a/packages/core/src/core.ts b/packages/core/src/core.ts
@@ -47,8 +47,8 @@ export default class ThemeMode {
             }
             if (this.options?.store && preference)
                 localStorage.setItem(this.options.store || 'theme-preference', preference)
-            this.host?.dispatchEvent(new CustomEvent('themePreferenceChange', { detail: this }))
             this._preference = preference
+            this.host?.dispatchEvent(new CustomEvent('themePreferenceChange', { detail: this }))
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -47,8 +47,8 @@ export default class ThemeMode {`
`47`	`47`	`}`
`48`	`48`	`if (this.options?.store && preference)`
`49`	`49`	`localStorage.setItem(this.options.store \|\| 'theme-preference', preference)`
`50`		`- this.host?.dispatchEvent(new CustomEvent('themePreferenceChange', { detail: this }))`
`51`	`50`	`this._preference = preference`
	`51`	`+ this.host?.dispatchEvent(new CustomEvent('themePreferenceChange', { detail: this }))`
`52`	`52`	`}`
`53`	`53`	`}`
`54`	`54`