Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github ??? #97

Open
AroKol78 opened this issue Jan 10, 2024 · 14 comments
Open

github ??? #97

AroKol78 opened this issue Jan 10, 2024 · 14 comments

Comments

@AroKol78
Copy link

Serpent52(20240105025008) + palefill1.27
Recently GH has messed up and the site has significantly slowed down which is beyond my tolerance for browsing.
I managed to capture the slowdown during which it displays strange things.
There would be a way around this?

Screenshot_1

https://github.com/uBlockOrigin/uAssets/commits/master/
ghbug0001

Screenshot_2

https://github.com/uBlockOrigin/uAssets
ghbug0002

@RamonUnch
Copy link

You may try to disable palefill on github, it is no longer required, However I am not sure anything can be done, even when disabling palefill GitHub is very slow for me as well and I have to restart the browser frequently, because of memory leaks.

If you disable palefill you may need to manually set dom.enable_performance_observer;true in about:config.

@martok
Copy link
Owner

martok commented Jan 16, 2024

Fascinating, the rendering glitch while loading aside, the new (React, I believe) version is significantly faster for me.

Edit, just to be clear: I'm not saying it is anywhere as fast as it was when they actually served HTML instead of constructing the view from 4 Megabytes of JS. But faster then, let's say, last summer.

and I have to restart the browser frequently, because of memory leaks.

That, on the other hand, has always been the case for me with Palemoon. Once the allocated memory exceeds ~1.5 GB, I just have to restart it. If I don't, at about 2G GC times just make it unresponsive.

@Vangelis66
Copy link

If you disable palefill, you may need to manually set dom.enable_performance_observer;true in about:config.

... Unlike official Pale Moon (and NM28), official Basilisk as well as Serpent 52 (OP's case) now have that pref default to true (i.e., there's no need to mess with it anymore in said browsers) 😉 ...

@jrfnl
Copy link

jrfnl commented Jan 30, 2024

I've been seeing the same rendering artifacts for quite a while now and find that the page loading is excruciatingly slow for things like the Milestone/Label dropdowns in issues/PRs.

As for the restarting, I do need to do this regularly as well, but generally only once it reached > 5G memory used. Might this be dependent on the total available memory ? (I have 64G available total).

@martok
Copy link
Owner

martok commented Jan 30, 2024

As for the restarting, I do need to do this regularly as well, but generally only once it reached > 5G memory used. Might this be dependent on the total available memory ? (I have 64G available total).

Huh, that's odd. 16GB total here, so 1/4. 5G/4 = 1.2G, thats awefully close for a coincidence. OTOH, my 8 GB laptop is still fine at 1GB for PM. The configurable thresholds are all absolute values, but maybe something internal isn't...

@AroKol78
Copy link
Author

AroKol78 commented Mar 29, 2024

it started pouring out errors

Error: SyntaxError: '[open]:not(:modal)' is not a valid selector
Source File: https://github.githubassets.com/assets/vendors-node_modules_oddbird_popover-polyfill_dist_popover_js-9da652f58479.js
Line: 1

and

Warning: Ignoring unsupported entryTypes: event.
Source File: https://github.githubassets.com/assets/behaviors-fca6f79d9550.js
Line: 33

@AroKol78
Copy link
Author

again :(

  1. you can wait forever, the worst thing is that you can't see longer issues
  2. the link does not open, you have to use it in a new tab to open it

Image

@jrfnl
Copy link

jrfnl commented Jan 17, 2025

@AroKol78 GitHub is working on a new issue view and it's horrible and doesn't work at all in Palemoon.
More info here: https://github.blog/changelog/2025-01-13-evolving-github-issues-public-preview

@SlySven
Copy link

SlySven commented Jan 18, 2025

I take it that if we moan at GH (https://github.com/orgs/community/discussions/148713) they'll say "Oh you should be using a modern supported browser."? Expecting everyone to swallow the Chromium cool-aide. 😡

@jrfnl
Copy link

jrfnl commented Jan 19, 2025

@SlySven @AroKol78 For the time being (once the roll-out has reached your account and you're not just seeing it because some organisation has opted-in), you can disable it from your account's "feature preview" settings:
image

Not sure how long that will last, but it helps for now.

@Vangelis66
Copy link

you can disable it

... Most sadly, however, this New Issues Experience abomination 😡 has been forced upon non-logged-in GitHub users without the option to disable the "Preview" 😞 ; so, if you're not already a GH member and want to read an open-source project's Issue Tracker, you're already screwed...

Microsoft employees 👎 seem to code only having latest ChrEdge (under Win11) as target client; every redesign of theirs is to the detriment of "older" browser engines (suitable for "older"/low-resourced H/W), UXP platform always paying a toll as a result of their "overhauls"; truth be told, GitHub has been in several ways broken under UXP (due to lingering CSS issues), but if you were prepared to turn a blind eye to those "cosmetic" annoyances, GH would still be function-able...

And the UXP team have probably thrown in the towel when it comes to these GitHub web-compat issues; I'm not optimistic myself this (and further) GH breakage will be properly addressed by them; the standard answer on the PM forums seems to be now "Use Firefox/Chromium" (sadly, the users of UXP forks on XP/Vista[/7] don't have that option; apart from, maybe, Supermium, but this is OT) ...

Not sure how long that will last

... Based on their previous "experiments" (e.g. the "Global Navigation Update"), it'll take from 3 to 6 months top until the "feature" becomes the norm; already foisted upon anonymous users, as I wrote above, so am leaning towards 3 months myself...

@jrfnl
Copy link

jrfnl commented Jan 19, 2025

@Vangelis66 Totally with you on the frustration. The diversity of the web is being broken and actively worked against by these type of changes. Forcing everyone onto (horrible, bad for privacy, no usability for large number of tabs etc etc) chromium-based browsers is a form of killing browser competition on the web and I'm just waiting for an anti-trust legal case.

@Vangelis66
Copy link

... This has now made it to the official PM Forums:

https://forum.palemoon.org/viewtopic.php?f=70&t=32021

It appears to be caused by code UXP doesn't support:

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/dialog

Chrome supported this early on (since v37), but Fx only relatively recently (since v98); Fx's implementation is, for sure, non "portable" as-is across to UXP...

@martok
Copy link
Owner

martok commented Jan 24, 2025

It appears to be caused by code UXP doesn't support:

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/dialog

Yes it does.

The selector is fixed upstream.

Repository owner locked as resolved and limited conversation to collaborators Jan 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants