Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numbers and commas spoken in Polish #2

Open
georgjaehnig opened this issue Aug 25, 2019 · 6 comments
Open

Numbers and commas spoken in Polish #2

georgjaehnig opened this issue Aug 25, 2019 · 6 comments

Comments

@georgjaehnig
Copy link

"3,4 milionoj" is spoken as "trzy przecinek cztery".

Probably a number preprocessor is needed, writing numbers as their Esperanto words.

@martinrue
Copy link
Owner

Good call, I'll think about the best way to do this.

@martinrue
Copy link
Owner

I've just deployed a change, adding the ability to say numbers. 🙌

Examples:
12345 should now be spoken: dekdu mil, tricent kvardek kvin.
49,7 should now be spoken: kvardek naŭ punkto sep.

It won't process very large numbers, but it should handle common cases up to hundreds of millions.

(Dates/times are a separate issue that still needs to be fixed.)

@georgjaehnig
Copy link
Author

Dziękuję! Seems to work well.

But why 49,7 with punkto, not komo? In Esperanto, apparently komo is used.

@georgjaehnig
Copy link
Author

Ho, ŝajne ĉe 24% ĝi daure estas pola elparolo.

@martinrue
Copy link
Owner

Dziękuję! Seems to work well.

But why 49,7 with punkto, not komo? In Esperanto, apparently komo is used.

Oops – I'll change it to say komo instead... thanks :)

@martinrue
Copy link
Owner

Ho, ŝajne ĉe 24% ĝi daure estas pola elparolo.

Yes – currently it only looks for numbers. Anything that doesn't look like a number by itself will be ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants