PlaintextKeys java.lang.NoClassDefFoundError

[igarshep]

Describe the bug

Using PlaintextKeys in my java application using the latest gp.jar gives:

java.lang.NoClassDefFoundError: pro/javacard/gp/PlaintextKeys
Caused by: java.lang.ClassNotFoundException: pro.javacard.gp.PlaintextKeys
at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:641)
at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:188)
at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:520)
... 9 more

Information about your card and used reader

As much information as you have:
Not sure how relevant it is

1. NXP
2. Identiv SPR332v2

Expected behavior

To be able to continue to use 3 bytes arrays for enc, mac, and dek using the PlaintextKeys class. In fact, the jar does not have any compile time issues and can find the references, but during runtime it does not seem to find the actual class to run.

Additional context

Previous versions of the jar did not have this issue. So either its intentionally being left out with no clear alternative, or this was a mistake. Hopefully the latter :)

[martinpaljak]

Plaintext keys moved to tool module for a reason I can't recall fully (dependencies, which I can't identify at the moment). https://github.com/martinpaljak/GlobalPlatformPro/blob/master/tool/src/main/java/pro/javacard/gptool/PlaintextKeys.java

[igarshep]

Which is where the visibility was lost, because the module-info.java does not export it. If you're okay with it being visible again, this looked pretty straightforward to expose on its own: #386

[martinpaljak]

Moved back to core library/module, but different package in 17e7d6c