Update IRequestHandler to return ValueTask instead of ValueTask<Unit>

[Dreamescaper]

I assume that this type was added for compatibility with MediatR. However, it is removed in latest MediatR versions - which is a good thing in my opinion, as it is much cleaner to write Task return type instead of Task<Unit>.

Does it make sense to remove it in the next major version?

[martinothamar]

Probably, I'll look into it as part of 3.0. It makes sense to keep up with MediatR API as much as possible

[zyofeng]

Any update on this? IT's one of the (small) obstacles that we are currently facing migrating from MediatR

[MaxLevs]

Any update on this? IT's one of the (small) obstacles that we are currently facing migrating from MediatR

I think if it's so important to migrate then u can use an adapter pattern

[zyofeng]

Im currently using the following interface as a workaround, not ideal though

public interface IRequestHandler<in TRequest> : IRequestHandler<TRequest, Unit>
    where TRequest : IRequest<Unit>
{
    new ValueTask Handle(TRequest request, CancellationToken cancellationToken);
    
    async ValueTask<Unit> IRequestHandler<TRequest, Unit>.Handle(TRequest request, CancellationToken cancellationToken)
    {
        await Handle(request, cancellationToken);
        return Unit.Value;
    }
}