Skip to content

Commit 4a4a86d

Browse files
committed
[racl_ctrl,rtl] Re-order racl_policy_t to match the register
Since SystemVerilog structs go from msb to lsb, this layout didn't match the register definitions. We *could* teach everything to do the reversal, but it's confusing for a reader. Switch things round now. Signed-off-by: Rupert Swarbrick <rswarbrick@lowrisc.org>
1 parent b2abffa commit 4a4a86d

4 files changed

Lines changed: 8 additions & 8 deletions

File tree

hw/top_darjeeling/rtl/autogen/top_racl_pkg.sv

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,8 @@ package top_racl_pkg;
4141

4242
// RACL policy containing a read and write permission
4343
typedef struct packed {
44-
racl_role_vec_t read_perm;
45-
racl_role_vec_t write_perm;
44+
racl_role_vec_t write_perm; // Write permission (upper bits)
45+
racl_role_vec_t read_perm; // Read permission (lower bits)
4646
} racl_policy_t;
4747

4848
// RACL policy vector for distributing RACL policies from the RACL widget to the subscribing IP

hw/top_earlgrey/rtl/autogen/top_racl_pkg.sv

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,8 @@ package top_racl_pkg;
4141

4242
// RACL policy containing a read and write permission
4343
typedef struct packed {
44-
racl_role_vec_t read_perm;
45-
racl_role_vec_t write_perm;
44+
racl_role_vec_t write_perm; // Write permission (upper bits)
45+
racl_role_vec_t read_perm; // Read permission (lower bits)
4646
} racl_policy_t;
4747

4848
// RACL policy vector for distributing RACL policies from the RACL widget to the subscribing IP

hw/top_englishbreakfast/rtl/autogen/top_racl_pkg.sv

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,8 @@ package top_racl_pkg;
4141

4242
// RACL policy containing a read and write permission
4343
typedef struct packed {
44-
racl_role_vec_t read_perm;
45-
racl_role_vec_t write_perm;
44+
racl_role_vec_t write_perm; // Write permission (upper bits)
45+
racl_role_vec_t read_perm; // Read permission (lower bits)
4646
} racl_policy_t;
4747

4848
// RACL policy vector for distributing RACL policies from the RACL widget to the subscribing IP

util/topgen/templates/top_racl_pkg.sv.tpl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,8 @@ package top_racl_pkg;
3535

3636
// RACL policy containing a read and write permission
3737
typedef struct packed {
38-
racl_role_vec_t read_perm;
39-
racl_role_vec_t write_perm;
38+
racl_role_vec_t write_perm; // Write permission (upper bits)
39+
racl_role_vec_t read_perm; // Read permission (lower bits)
4040
} racl_policy_t;
4141

4242
// RACL policy vector for distributing RACL policies from the RACL widget to the subscribing IP

0 commit comments

Comments
 (0)