Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Change DateFilter value from string to DateTimeImmutable #199

Open
mariosimao opened this issue Apr 16, 2023 · 0 comments
Open

[FEATURE] Change DateFilter value from string to DateTimeImmutable #199

mariosimao opened this issue Apr 16, 2023 · 0 comments
Labels
enhancement New feature or request
Milestone
v2

Comments

@mariosimao
Copy link
Owner

mariosimao commented Apr 16, 2023 •
edited
Loading

It makes no sense to filter by a date providing a string instead of a date object.

Also remove the array type from the value property since it has been replaced by stdClass.

Since this is a change on the SKD's public API, it should be released on v2.
@mariosimao mariosimao added the enhancement New feature or request label Apr 16, 2023
@mariosimao mariosimao added this to the v2 milestone Apr 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v2
Development

No branches or pull requests
1 participant
@mariosimao