Skip to content

Commit 360d598

Browse files
authored
Merge pull request #1 from juissi-t/fix-pylint-execution
Fix pylint execution
2 parents 16aad1c + facb5c7 commit 360d598

File tree

3 files changed

+16
-16
lines changed

3 files changed

+16
-16
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
Zero-configuration GitHub Action to maintain code quality with push and PR annotations.
44

55
On every push and pull request git diffs will get inline annotated with found errors from
6-
selected lintners.
6+
selected linters.
77

88
![Screenshot of annotations](static/annotations.png)
99

@@ -72,7 +72,7 @@ isort==isort-5.7.0
7272

7373
The python version you set up in your action script with `actions/setup-python@v2`
7474
or by other means will not affect the linting process. The python version used by
75-
the lintners can be set up only by `conda-python-version` argument! This also means
75+
the linters can be set up only by `conda-python-version` argument! This also means
7676
that if you modify the system conda environment it might affect the lintnig process.
7777
So it is best to keep the lintnig action separated from others. It is also recomended
7878
to run this on `ubuntu-latest`. Example:

action.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,12 +84,12 @@ runs:
8484
$CONDA/bin/conda --version
8585
$CONDA/bin/conda install python=${{ inputs.conda-python-version }}
8686
shell: bash
87-
name: Install lintners
87+
name: Install linters
8888
- run: |
8989
$CONDA/bin/python --version
9090
$CONDA/bin/pip install -r ${{ github.action_path }}/requirements.txt
9191
shell: bash
92-
name: Install lintners
92+
name: Install linters
9393
- run: >
9494
${{ github.action_path }}/entrypoint.sh
9595
'${{ inputs.python-root-list }}'

entrypoint.sh

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
# $7 - use-isort
1212
# $8 - use-vulture
1313
# $9 - use-pydocstyle
14-
# $10 - extra-pylint-options
14+
# ${10} - extra-pylint-options
1515
# ${11} - extra-pycodestyle-options
1616
# ${12} - extra-flake8-options
1717
# ${13} - extra-black-options
@@ -29,14 +29,14 @@ echo use-mypy: $6
2929
echo use-isort: $7
3030
echo use-vulture: $8
3131
echo use-pydocstyle $9
32-
echo extra-pylint-options: $10
33-
echo extra-pycodestyle-options: $11
34-
echo extra-flake8-options: $12
35-
echo extra-black-options: $13
36-
echo extra-mypy-options: $14
37-
echo extra-isort-options: $15
38-
echo extra-vulture-options: $16
39-
echo extra-pydocstyle-options: $17
32+
echo extra-pylint-options: ${10}
33+
echo extra-pycodestyle-options: ${11}
34+
echo extra-flake8-options: ${12}
35+
echo extra-black-options: ${13}
36+
echo extra-mypy-options: ${14}
37+
echo extra-isort-options: ${15}
38+
echo extra-vulture-options: ${16}
39+
echo extra-pydocstyle-options: ${17}
4040

4141
# actions path has the copy of this actions repo
4242
for matcher in $GITHUB_ACTION_PATH/matchers/*.json
@@ -49,9 +49,9 @@ export TERM=xterm
4949

5050
if [ "$2" = true ] ; then
5151

52-
echo Running: pylint $9 $1
52+
echo Running: pylint ${10} $1
5353

54-
$CONDA/bin/pylint --output-format="colorized" $9 $1
54+
$CONDA/bin/pylint --output-format="colorized" ${10} $1
5555
exit_code=$?
5656

5757
if [ "$exit_code" = "0" ]; then
@@ -165,4 +165,4 @@ if [ "$9" = true ] ; then
165165
echo "pycodestyle error"
166166
fi
167167

168-
fi
168+
fi

0 commit comments

Comments
 (0)