From d5c8fb3a6ff80e3871644b410f4dc8f7f1cfac64 Mon Sep 17 00:00:00 2001
From: Andrew March <youthclubrecords@gmail.com>
Date: Wed, 13 Sep 2023 02:18:40 -0300
Subject: [PATCH] use fixed point for pitch bend algo

---
 src/fp.h         | 42 ++++++++++++++++++++++++++++++++++++++++++
 src/wav_player.c | 18 +++++++++++++-----
 2 files changed, 55 insertions(+), 5 deletions(-)
 create mode 100644 src/fp.h

diff --git a/src/fp.h b/src/fp.h
new file mode 100644
index 0000000..3915a79
--- /dev/null
+++ b/src/fp.h
@@ -0,0 +1,42 @@
+#ifndef FP_H
+#define FP_H
+
+#include "stdint.h"
+
+int32_t fxdiv_s15p16 (int32_t x, int32_t y)
+{
+    return ((int64_t)x * 65536) / y;
+}
+
+/* log2(2**8), ..., log2(2**1), log2(1+2**(-1), ..., log2(1+2**(-16)) */
+const uint32_t tab [20] = {0x80000, 0x40000, 0x20000, 0x10000,
+                           0x095c1, 0x0526a, 0x02b80, 0x01663,
+                           0x00b5d, 0x005b9, 0x002e0, 0x00170, 
+                           0x000b8, 0x0005c, 0x0002e, 0x00017, 
+                           0x0000b, 0x00006, 0x00003, 0x00001};
+const int32_t one_s15p16 = 1 * (1 << 16);
+const int32_t neg_fifteen_s15p16 = (-15) * (1 << 16);
+
+int32_t fxexp2_s15p16 (int32_t a) 
+{
+    uint32_t x, y;
+    int32_t t, r;
+
+    if (a <= neg_fifteen_s15p16) return 0; // underflow
+
+    x = (a < 0) ? (-a) : (a);
+    y = one_s15p16;
+    /* process integer bits */
+    if ((t = x - tab [0]) >= 0) { x = t; y = y << 8; }
+    if ((t = x - tab [1]) >= 0) { x = t; y = y << 4; }
+    if ((t = x - tab [2]) >= 0) { x = t; y = y << 2; }
+    if ((t = x - tab [3]) >= 0) { x = t; y = y << 1; }
+    /* process fractional bits */
+    for (int shift = 1; shift <= 16; shift++) {
+        if ((t = x - tab [3 + shift]) >= 0) { x = t; y = y + (y >> shift); }
+    }
+    r = (a < 0) ? fxdiv_s15p16 (one_s15p16, y) : y;
+    return r;
+}
+
+#endif
\ No newline at end of file
diff --git a/src/wav_player.c b/src/wav_player.c
index 1e8cb66..dda14d3 100644
--- a/src/wav_player.c
+++ b/src/wav_player.c
@@ -17,6 +17,7 @@
 #include "ws_log.h"
 #include "rpc.h"
 #include "wav_player.h"
+#include "fp.h"
 
 static const char* TAG = "wav_player";
 
@@ -226,12 +227,19 @@ void update_pitch_bends(void)
 {
   for(int i=0; i<16; i++)
   {
+    // uint16_t pitch_bend = channel_pitch_bend[i];
+    // float bend = pitch_bend / 8192.0 - 1.0;
+    // float semitones = bend >= 0 ? metadata.pitch_bend_semitones_up * bend : metadata.pitch_bend_semitones_down * bend;
+    // float exponent = semitones / 12.0;
+    // float pitch_factor = pow(2, exponent);
+    // pitch_bend_factor[i] = pitch_factor * 0x10000;
+
     uint16_t pitch_bend = channel_pitch_bend[i];
-    float bend = pitch_bend / 8192.0 - 1.0;
-    float semitones = bend >= 0 ? metadata.pitch_bend_semitones_up * bend : metadata.pitch_bend_semitones_down * bend;
-    float exponent = semitones / 12.0;
-    float pitch_factor = pow(2, exponent);
-    pitch_bend_factor[i] = pitch_factor * 0x10000;
+    int32_t bend = (pitch_bend << 16) / 8192.0 - ( 1 << 16);
+    int32_t semitones = bend >= 0 ? metadata.pitch_bend_semitones_up * bend : metadata.pitch_bend_semitones_down * bend;
+    int32_t exponent = semitones / 12;
+    int32_t pitch_factor = fxexp2_s15p16(exponent);
+    pitch_bend_factor[i] = pitch_factor;
   }
 }