MapLibre w/ Vite > 8.0.0 Broken

[ingalls]

maplibre-gl-js version: 5.21.0, 5.21.1 (Haven't tested earlier versions)
browser: Chrome, Firefox

Steps to Trigger Behavior

1. Make a production build with vite@8.0.3
2. Trigger a GeoJSON Diff update
3. Check console for errors

Browser Stack Trace:

Object { message: "Ia is not defined", stack: "" }
​
message: "Ia is not defined"
​
stack: ""
​
<prototype>: Error.prototype { stack: "", … }
[map-BFZA0AX5.js:2:245620](https://map.cotak.org/assets/map-BFZA0AX5.js)
    fire https://map.cotak.org/assets/map-BFZA0AX5.js:2
    fire https://map.cotak.org/assets/map-BFZA0AX5.js:2
    fire https://map.cotak.org/assets/map-BFZA0AX5.js:2
    _dispatchWorkerUpdate https://map.cotak.org/assets/map-BFZA0AX5.js:2
    s https://map.cotak.org/assets/map-BFZA0AX5.js:2
    (Async: promise callback)
    c https://map.cotak.org/assets/map-BFZA0AX5.js:2
    o https://map.cotak.org/assets/map-BFZA0AX5.js:2
    (Async: promise callback)
    c https://map.cotak.org/assets/map-BFZA0AX5.js:2
    t https://map.cotak.org/assets/map-BFZA0AX5.js:2
    t https://map.cotak.org/assets/map-BFZA0AX5.js:2
    _dispatchWorkerUpdate https://map.cotak.org/assets/map-BFZA0AX5.js:2
    _updateWorkerData https://map.cotak.org/assets/map-BFZA0AX5.js:2
    t https://map.cotak.org/assets/map-BFZA0AX5.js:2
    t https://map.cotak.org/assets/map-BFZA0AX5.js:2
    _updateWorkerData https://map.cotak.org/assets/map-BFZA0AX5.js:2
    updateData https://map.cotak.org/assets/map-BFZA0AX5.js:2
    updateCOT https://map.cotak.org/assets/map-BFZA0AX5.js:757
    i https://map.cotak.org/assets/map-BFZA0AX5.js:2
    refresh https://map.cotak.org/assets/map-BFZA0AX5.js:757
    i https://map.cotak.org/assets/map-BFZA0AX5.js:2
    value https://map.cotak.org/assets/Map-BPFoAeIC.js:8
    (Async: setInterval handler)
    qe https://map.cotak.org/assets/Map-BPFoAeIC.js:8
    fire https://map.cotak.org/assets/map-BFZA0AX5.js:2
    _render https://map.cotak.org/assets/map-BFZA0AX5.js:757
    triggerRepaint https://map.cotak.org/assets/map-BFZA0AX5.js:757
    o https://map.cotak.org/assets/map-BFZA0AX5.js:2
    (Async: FrameRequestCallback)
    frame https://map.cotak.org/assets/map-BFZA0AX5.js:2
    triggerRepaint https://map.cotak.org/assets/map-BFZA0AX5.js:757
    _update https://map.cotak.org/assets/map-BFZA0AX5.js:757
    to https://map.cotak.org/assets/map-BFZA0AX5.js:757
    fire https://map.cotak.org/assets/map-BFZA0AX5.js:2
    fire https://map.cotak.org/assets/map-BFZA0AX5.js:2
    _loadSprite https://map.cotak.org/assets/map-BFZA0AX5.js:755
    _loadSprite https://map.cotak.org/assets/map-BFZA0AX5.js:755
    _load https://map.cotak.org/assets/map-BFZA0AX5.js:755
    loadJSON https://map.cotak.org/assets/map-BFZA0AX5.js:755
    (Async: promise callback)
    loadJSON https://map.cotak.org/assets/map-BFZA0AX5.js:755
    _updateStyle https://map.cotak.org/assets/map-BFZA0AX5.js:757
    setStyle https://map.cotak.org/assets/map-BFZA0AX5.js:757
    to https://map.cotak.org/assets/map-BFZA0AX5.js:757
    init https://map.cotak.org/assets/map-BFZA0AX5.js:757
    i https://map.cotak.org/assets/map-BFZA0AX5.js:2
    qe https://map.cotak.org/assets/Map-BPFoAeIC.js:8
    setup https://map.cotak.org/assets/Map-BPFoAeIC.js:8
    zr https://map.cotak.org/assets/runtime-core.esm-bundler-Chk7BC6l.js:1
    pn https://map.cotak.org/assets/runtime-core.esm-bundler-Chk7BC6l.js:1
    z https://map.cotak.org/assets/runtime-core.esm-bundler-Chk7BC6l.js:1
    __weh https://map.cotak.org/assets/runtime-core.esm-bundler-Chk7BC6l.js:1
    Dn https://map.cotak.org/assets/runtime-core.esm-bundler-Chk7BC6l.js:1
    kn https://map.cotak.org/assets/runtime-core.esm-bundler-Chk7BC6l.js:1

I don't think this is necessarily actionable by the MapLibre team as initial testing points to a problem in vite but posting to surface the interaction right now and track progress.

[CommanderStorm]

Can you share a minimum reproducible example via jsbin?
Is your target < ES2022?

I think this is related to this issue which we merged last week:

• _defineProperty is not defined after upgrading to maplibre-gl 5.17.0 #7069

[ingalls]

Still working on reproduction, JSBin isn't easy to use to build a reproducible case as it's the build output that fails and not the actual Maplibre runtime.

I've tested maplibre 5.21.1 on vite 8.0.0 (Works), 8.0.1 (Failing), 8.0.2 (Failing), 8.0.3 (Failing). I should also note that the vite devserver seems to work just fine, only the built output causes a failure.

I'm currently using the default vite8 target which is baseline-widely-available

[HarelM]

8.x are not maplibre-gl-js versions.
Are you confusing this with another library?

[CommanderStorm]

@HarelM see the issue title and body: MapLibre WITH vite>=v8.0.1

[HarelM]

If vite broke something in the new version I would consider starting opening a big there, was this done?

[BryonLewis]

I'm noticing the same problem using maplbire-gl 5.21.1 and vite 8.0.1, 8.0.2, 8.0.3
Same behavior with the dev version working properly but the production one is getting an undefined error.
I haven't simplified it to a representative example, but my code is specifically creating a clustering map (very similar to the example) and loading geoJSON from an endpoint.

If I force it to build in production using maplibre-gl-dev.js instead of maplibre-gl.js it will work.

For some more information, I did some previous version testing and with Vite: 8.03 maplibre-gl: 5.17.0 will work but 5.18.0 won't working.

I'm wondering if it has something to do with #7058. But as indicated in earlier comments, it is probably a regression with vite itself.

[HarelM]

Can you check if you build a version without the "..." in the geojson source, does it solve the problem?

[Chandelier-02]

For those that have been experiencing this issue, using the csp-worker maplibre provides has been a good workaround for me.
maplibregl.setWorkerUrl('/assets/maplibre-gl-csp-worker.js');