Skip to content

Commit 6cb9869

Browse files
ibesoragithub-actions[bot]
authored andcommitted
Fix wrong symbol vertices being updated by appearance (internal-7245)
GitOrigin-RevId: 3891febf1cff80f8203de4dd8aa430f1f1d0610a
1 parent e4c9bb6 commit 6cb9869

File tree

3 files changed

+20
-4
lines changed

3 files changed

+20
-4
lines changed

src/data/bucket/symbol_bucket.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1037,6 +1037,8 @@ class SymbolBucket implements Bucket {
10371037
vertexOffset += featureData.layoutBasedVertexData.length;
10381038
featureData.isUsingAppearanceVertexData = false;
10391039
reuploadBuffer = true;
1040+
} else {
1041+
vertexOffset += symbolInstance.numIconVertices;
10401042
}
10411043
}
10421044
}
2.31 KB
Loading

test/integration/render-tests/appearance/feature-state/style.json

Lines changed: 18 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,23 +2,22 @@
22
"version": 8,
33
"metadata": {
44
"test": {
5-
"allowed": 0.00037,
5+
"allowed": 0.00043,
66
"pixelRatio": 2,
77
"height": 64,
88
"width": 64,
99
"operations": [
1010
["wait"],
1111
["setFeatureState", {
1212
"source": "geojson",
13-
"id": 1
13+
"id": 2
1414
}, {
1515
"hover": true
1616
}],
1717
["wait"]
1818
]
1919
}
2020
},
21-
"camera": {"camera-projection": "orthographic"},
2221
"sources": {
2322
"geojson": {
2423
"type": "geojson",
@@ -34,7 +33,21 @@
3433
"geometry": {
3534
"type": "Point",
3635
"coordinates": [
37-
0,
36+
-5,
37+
0
38+
]
39+
}
40+
},
41+
{
42+
"id": 2,
43+
"type": "Feature",
44+
"properties": {
45+
"image": "bank-12"
46+
},
47+
"geometry": {
48+
"type": "Point",
49+
"coordinates": [
50+
5,
3851
0
3952
]
4053
}
@@ -50,6 +63,7 @@
5063
"type": "symbol",
5164
"source": "geojson",
5265
"layout": {
66+
"icon-allow-overlap": true,
5367
"icon-image": "bank-12",
5468
"icon-size": 1,
5569
"icon-rotate": 0,

0 commit comments

Comments
 (0)