Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onKeyDown in Combobox not firing in Safari when target is not an input text field #7386

Open
1 of 2 tasks
elibroftw opened this issue Jan 20, 2025 · 1 comment
Open
1 of 2 tasks

Comments

@elibroftw
Copy link

Dependencies check up

  • I have verified that I use latest version of all @mantine/* packages

What version of @mantine/* packages do you have in package.json?

7.16.1

What package has an issue?

@mantine/core

What framework do you use?

Vite

In which browsers you can reproduce the issue?

Safari

Describe the bug

When using a basic select demo in Safari, netiher the escape key closes the combobox, nor does the arrow up/down key work to select a different item. Rather the arrow up and down key move the page.

If possible, include a link to a codesandbox with a minimal reproduction

https://mantine.dev/combobox/?e=BasicSelect

Possible fix

Seems like focus needs to be trapped when using a target other than text field input.

Self-service

  • I would be willing to implement a fix for this issue
@elibroftw
Copy link
Author

I can confirm that focus trapping worked without having to edit the mantine packages, but would be great to have this already done within the mantine package either using a focus trap or doing what the modal does with the window event.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant