Skip to content

fix: add validation for aggregate functions on text columns #3883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 6, 2025
Merged

fix: add validation for aggregate functions on text columns #3883

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7d6f131
fix: add validation for aggregate functions on string/text columns in…
sanikolaev Nov 1, 2025
0117bd0
fix: move validation for aggregate functions on string/text columns t…
sanikolaev Nov 1, 2025
4ef1c20
Merge branch 'master' into issue-3844-2
sanikolaev Nov 1, 2025
786eabf
ci: added CLT test for issue https://github.com/manticoresoftware/man…
sanikolaev Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/queuecreator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -842,6 +842,19 @@ bool QueueCreator_c::SetupAggregateExpr ( CSphColumnInfo & tExprCol, const CSphS
if ( tExprCol.m_eAggrFunc!=SPH_AGGR_NONE && tExprCol.m_eAttrType==SPH_ATTR_JSON_FIELD )
return Err ( "ambiguous attribute type '%s', use INTEGER(), BIGINT() or DOUBLE() conversion functions", sExpr.cstr() );

// validate that MAX/MIN/SUM/AVG cannot be used on string/text columns
if ( tExprCol.m_eAggrFunc==SPH_AGGR_MAX || tExprCol.m_eAggrFunc==SPH_AGGR_MIN
|| tExprCol.m_eAggrFunc==SPH_AGGR_SUM || tExprCol.m_eAggrFunc==SPH_AGGR_AVG )
{
if ( tExprCol.m_eAttrType==SPH_ATTR_STRING || tExprCol.m_eAttrType==SPH_ATTR_STRINGPTR )
{
const char * sFunc = ( tExprCol.m_eAggrFunc==SPH_AGGR_MAX ) ? "MAX"
: ( tExprCol.m_eAggrFunc==SPH_AGGR_MIN ) ? "MIN"
: ( tExprCol.m_eAggrFunc==SPH_AGGR_SUM ) ? "SUM" : "AVG";
return Err ( "%s() cannot be used on text/string column '%s'", sFunc, sExpr.cstr() );
}
}

if ( uQueryPackedFactorFlags & SPH_FACTOR_JSON_OUT )
tExprCol.m_eAttrType = SPH_ATTR_FACTORS_JSON;

Expand Down
Loading