Skip to content

Commit df42ada

Browse files
authored
Merge pull request #10 from jeremiahlukus/master
update ruby version, sqlite version, and fix tests
2 parents 6355b51 + d107f9e commit df42ada

9 files changed

Lines changed: 49 additions & 23 deletions

File tree

.github/workflows/test.yml

Lines changed: 39 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,39 @@
1+
name: Test
2+
3+
on:
4+
push:
5+
branches: [ master ]
6+
pull_request:
7+
branches: [ master ]
8+
9+
jobs:
10+
test:
11+
runs-on: ubuntu-latest
12+
strategy:
13+
fail-fast: false
14+
matrix:
15+
ruby-version: ['3.3', 'jruby-9.4']
16+
17+
steps:
18+
- uses: actions/checkout@v4
19+
20+
- name: Set up Ruby ${{ matrix.ruby-version }}
21+
uses: ruby/setup-ruby@v1
22+
with:
23+
ruby-version: ${{ matrix.ruby-version }}
24+
bundler-cache: true
25+
26+
- name: Update RubyGems
27+
run: gem update --system
28+
29+
- name: Show versions
30+
run: |
31+
gem --version
32+
bundler --version
33+
ruby --version
34+
35+
- name: Install dependencies
36+
run: bundle install
37+
38+
- name: Run tests
39+
run: bundle exec rspec

.ruby-version

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
ruby-1.9.3
1+
3.3.0

.travis.yml

Lines changed: 0 additions & 15 deletions
This file was deleted.

Gemfile.jruby

Lines changed: 0 additions & 3 deletions
This file was deleted.

lib/data/vehicle.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,11 @@ def self.get_vehicle(params)
2020
end
2121

2222
def self.perform_joins(params)
23-
params.keys.inject(from(:vehicles)) { |r, e| r.join("#{e}s".to_sym, :id => "vehicles__#{e}_id".to_sym) }
23+
params.keys.inject(from(:vehicles)) { |r, e| r.join("#{e}s".to_sym, :id => Sequel.qualify(:vehicles, "#{e}_id".to_sym)) }
2424
end
2525

2626
def self.add_conditions_to_join(join_query, params)
27-
params.inject(join_query) { |r, e| r.where("#{e.first}s__name".to_sym => e.last) }
27+
params.inject(join_query) { |r, e| r.where(Sequel.qualify("#{e.first}s".to_sym, :name) => e.last) }
2828
end
2929

3030
def self.get_random_vehicle

lib/vinbot.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
require 'securerandom'
22
require 'sequel'
33
require 'vin_bank'
4+
require 'vinbot/version'
45
require 'vinbot/vehicle'
56
require 'vinbot/vin'
67

lib/vinbot/version.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
module Vinbot
2-
VERSION = "2.0.4"
2+
VERSION = "3.0.0"
33
end

vinbot-jruby.gemspec

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@ Gem::Specification.new do |spec|
1515
spec.homepage = "https://github.com/manheim/vinbot"
1616
spec.license = "MIT"
1717

18+
spec.required_ruby_version = ">= 3.0.0"
19+
1820
spec.files = Dir["lib/**/*"]
1921
spec.bindir = "exe"
2022
spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }

vinbot.gemspec

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@ Gem::Specification.new do |spec|
1414
spec.homepage = "https://github.com/manheim/vinbot"
1515
spec.license = "MIT"
1616

17+
spec.required_ruby_version = ">= 3.0.0"
18+
1719
spec.files = Dir["lib/**/*"]
1820
spec.bindir = "exe"
1921
spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
@@ -24,7 +26,7 @@ Gem::Specification.new do |spec|
2426
spec.add_development_dependency "rspec"
2527
spec.add_development_dependency "pry"
2628
spec.add_development_dependency "pry-nav"
27-
spec.add_runtime_dependency "sqlite3"
29+
spec.add_runtime_dependency "sqlite3", "~> 2.7.3"
2830
spec.add_runtime_dependency "sequel"
2931
spec.add_runtime_dependency "vin_bank", ">= 3.1.0"
3032
end

0 commit comments

Comments
 (0)