Switch low level chunked_buffer checks to debug

The checks in particular getting the `physical_bytes` introduced a
slowdown in `BM_iteration_via_scalar_at` because:
- Previously `bytes()` call could be inlined and it can no longer be
  inlined because of the runtime polymorphism
- The non inlined function calls are taking a big part of the time.

Removing the check in `operator[]` removes two function calls in release
builds. This brings performance roughly inline to before the refactor.

Author: IvoDD

cpp/arcticdb/column_store/chunked_buffer.hpp

@@ -342,7 +342,7 @@ class ChunkedBufferImpl {
 
     uint8_t* bytes_at(size_t pos_bytes, size_t required) {
         auto [block, pos, _] = block_and_offset(pos_bytes);
-        util::check(
+        debug::check<ErrorCode::E_ASSERTION_FAILURE>(
                 pos + required <= block->physical_bytes(),
                 "Block overflow, position {} is greater than block capacity {}",
                 pos + required,
@@ -357,7 +357,7 @@ class ChunkedBufferImpl {
 
     uint8_t& operator[](size_t pos_bytes) {
         auto [block, pos, _] = block_and_offset(pos_bytes);
-        util::check(
+        debug::check<ErrorCode::E_ASSERTION_FAILURE>(
                 pos < block->physical_bytes(),
                 "Block overflow, position {} is greater than block capacity {}",
                 pos,
@@ -390,19 +390,16 @@ class ChunkedBufferImpl {
     [[nodiscard]] uint8_t* data() { return const_cast<uint8_t*>(const_cast<const ChunkedBufferImpl*>(this)->data()); }
 
     void check_bytes(size_t pos_bytes, size_t required_bytes) const {
-        if (pos_bytes + required_bytes > bytes()) {
-            std::string err = fmt::format(
-                    "Cursor overflow in chunked_buffer ptr_cast, cannot read {} bytes from a buffer of size {} with "
-                    "cursor "
-                    "at {}, as it would require {} bytes. ",
-                    required_bytes,
-                    bytes(),
-                    pos_bytes,
-                    pos_bytes + required_bytes
-            );
-            ARCTICDB_DEBUG(log::storage(), err);
-            throw std::invalid_argument(err);
-        }
+        debug::check<ErrorCode::E_ASSERTION_FAILURE>(
+                pos_bytes + required_bytes <= bytes(),
+                "Cursor overflow in chunked_buffer ptr_cast, cannot read {} bytes from a buffer of size {} with "
+                "cursor "
+                "at {}, as it would require {} bytes. ",
+                required_bytes,
+                bytes(),
+                pos_bytes,
+                pos_bytes + required_bytes
+        );
     }
 
     // Returns a vector of continuous buffers, each designated by a pointer and size

cpp/arcticdb/column_store/test/benchmark_memory_segment.cpp

@@ -114,8 +114,8 @@ static void BM_iterate_with_scalar_at(benchmark::State& state) {
     [[maybe_unused]] auto acc = 0ull;
     for (auto _ : state) {
         // Starting col from 1 to skip the index
-        for (auto col=1; col<=num_cols; ++col) {
-            for (auto row=0; row<num_rows; ++row) {
+        for (auto col = 1; col <= num_cols; ++col) {
+            for (auto row = 0; row < num_rows; ++row) {
                 acc += segment.scalar_at<uint64_t>(row, col).value_or(0);
             }
         }
@@ -130,12 +130,14 @@ static void BM_iterate_with_iterator(benchmark::State& state) {
     [[maybe_unused]] auto acc = 0ull;
     for (auto _ : state) {
         // Starting col from 1 to skip the index
-        for (auto col=1; col<=num_cols; ++col) {
+        for (auto col = 1; col <= num_cols; ++col) {
             auto data = segment.column(col).data();
             using tdt = ScalarTagType<DataTypeTag<DataType::UINT64>>;
-            std::for_each(data.cbegin<tdt, IteratorType::REGULAR, IteratorDensity::DENSE>(), data.cend<tdt, IteratorType::REGULAR, IteratorDensity::DENSE>(), [&](auto v) {
-                acc += v;
-            });
+            std::for_each(
+                    data.cbegin<tdt, IteratorType::REGULAR, IteratorDensity::DENSE>(),
+                    data.cend<tdt, IteratorType::REGULAR, IteratorDensity::DENSE>(),
+                    [&](auto v) { acc += v; }
+            );
         }
     }
 }