Portnames: can't resave .json.

[Firehawke]

@cracyc
One simple, to the point issue:

1. You can't have the plugin load existing data, then fill in the blanks again for removed data.

You can test this by loading sf2 with the plugin in place. Note that the six action buttons are renamed correctly. Go into plugins, and try to save the data again. You'll get the error "portname: input name file exists sf2.json"
You probably will want to allow overwrites using .json over-top MAME information. in the case of SF2 I found a bit of missing info I wanted to pass back upstream to you but had to rename the .json file so I could regenerate the original data and then hand-merge the two.

Removed number 2 as it was completely incorrect and a waste of your time to read.

I am likely to contribute some information from my side in the near future; fixing issue 1 above would make that significantly easier.

[Firehawke]

I was completely wrong on issue 2 and have removed it. SF2CEUA isn't using SF2 as parent, it's SF2CE and SF2CE isn't a child set. Which means your data set is missing SF2CE and I misunderstood the root cause.

[cracyc]

I can't test or commit it right now but this patch should work.

diff --git "a/plugins/portname/init.lua" "b/plugins/portname/init.lua"
index 3c04d26..e79bf05 100644
--- "a/plugins/portname/init.lua"
+++ "b/plugins/portname/init.lua"
@@ -149,14 +149,7 @@ function portname.startplugin()
 				return false
 			end
 			local filename = get_filename()
-			local file = io.open(ctrlrpath .. "/portname/" .. filename, "r")
-			if file then
-				emu.print_verbose("portname: input name file exists " .. filename .. "\n")
-				manager:machine():popmessage(_("Failed to save input name file"))
-				file:close()
-				return false
-			end
-			file = io.open(ctrlrpath .. "/portname/" .. filename, "w")
+			local file = io.open(ctrlrpath .. "/portname/" .. filename, "w+")
 			local ctable = { romname = emu.romname(), ports = ports }
 			if emu.softname() ~= "" then
 				ctable.softname = emu.softname()

I found a bit of missing info I wanted to pass back upstream to you but had to rename the .json file so I could regenerate the original data and then hand-merge the two.

The repo I linked isn't mine. Mine is at https://github.com/cracyc/mame-portnames but it doesn't include all the changes from EoceneMiacid's.

[Firehawke]

Well, we'll need to sit down and see about getting all of this solidified into one master distribution assuming this can't make it actually INTO MAME itself (which seems as likely as MAMEINFO, etc making it in-- that is to say not at all).

Feel free to contact me on Discord/IRC if you'd like to speak further on this subject but I'm going to be at least somewhat non-responsive for a bit of time (days? weeks?) because I've managed to injure my right wrist again. sigh.