Build problems with spaces in pathnames

[publiusrgj]

I just stumbled across Yori here and love it. For fun, I decided to build it using the VS2022 toolchain, and stumbled on a problem with spaces in the pathname for the build directory. I built it on my main desktop, which went fine for both AMD64 and x64, and then tried it on a laptop, and got some strange error messages from NMAKE when it was attempting to copy the .pdb files to the symbols directory as part of the install target processing.

It turns out that was due to spaces in the path name I'd placed the source code on the laptop. It was under my user home directory on the laptop, which just has one big C drive, and the username had spaces in it (I hate spaces in paths anyway, but that's how it worked out during Windows 10 setup). It was these lines in "config\common.mk" that triggered the error:

@if not "$(BINARIES)."=="." for %%i in ($(BINARIES)) do @if exist %%~dpni.pdb copy %%~dpni.pdb $(SYMDIR) >NUL

@if not "$(MODULES)."=="." for %%i in ($(MODULES)) do @if exist %%~dpni.pdb copy %%~dpni.pdb $(SYMDIR) >NUL

Don't know if it's worth the trouble to try to fix that to handle spaces in paths, or just put a warning not to use pathnames with spaces.

[malxau]

Thanks for letting me know. It looks like supporting spaces here is straightforward – it can either have quotes around %~dpni arguments or just remove the dp part. The binaries seem to be copied as relative paths, but the symbols were using %~dpni which resolves to a full path, so using relative paths for both should work. Commit fe63688 .

[publiusrgj]

That did the trick. Thanks. Yori is a very nice work, indeed.