Skip to content

Commit 4e026ba

Browse files
committed
Refrain from comparing vcmax25 and jmax25 with rpmodel
1 parent 1d590f8 commit 4e026ba

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

tests/testthat/test-model-runs.R

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -278,7 +278,8 @@ test_that("p-model onestep output check (run_pmodel_onestep_f_bysite())", {
278278
# NOTE: is now: (3.39e-6 g C m-2 s-1) # still slightly different from 3.16e-6, but remains within tolerance
279279
dplyr::select(-ns_star, -xi, -mj, -mc, -ci,
280280
-gpp, -ca, -gammastar, -kmm) |>
281-
dplyr::select(vcmax, jmax, vcmax25, jmax25, chi, gs, iwue, rd)
281+
dplyr::select(vcmax, jmax, vcmax25, jmax25, chi, gs, iwue, rd) |>
282+
dplyr::select(-vcmax25, -jmax25) # NOTE: as long as rpmodel is not updated with Kumarathunge T-dependency, we can only compare vcmax and jmax
282283

283284
resF_units_fixed <- resF |>
284285
dplyr::mutate(
@@ -289,7 +290,8 @@ test_that("p-model onestep output check (run_pmodel_onestep_f_bysite())", {
289290
iwue = iwue, # NOTE: keep units as-is: (-) (computed as (ca-ci)/1.6/patm)
290291
rd = rd) |> # NOTE: keep units as-is: 3.16e-6 g C m-2 s-1 (computed as rd_to_vcmax*vcmax25*calc_ftemp_inst_rd(Temp)*c_molmass
291292
dplyr::select(-wscal, -gs_accl) |>
292-
dplyr::select(vcmax, jmax, vcmax25, jmax25, chi, gs, iwue, rd)
293+
dplyr::select(vcmax, jmax, vcmax25, jmax25, chi, gs, iwue, rd) |>
294+
dplyr::select(-vcmax25, -jmax25) # NOTE: as long as rpmodel is not updated with Kumarathunge T-dependency, we can only compare vcmax and jmax
293295

294296

295297
# Now comparison must pass

0 commit comments

Comments
 (0)