Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds detailed rubric requirements to challenge readme #236

Closed
wants to merge 4 commits into from
Closed

adds detailed rubric requirements to challenge readme #236

wants to merge 4 commits into from

Conversation

tansaku
Copy link
Contributor

@tansaku tansaku commented Nov 24, 2015

closes #230

@tansaku tansaku added the QA label Nov 24, 2015
dbugsy
dbugsy reviewed Nov 24, 2015
View reviewed changes
docs/review.md
expect(subject.planes).to include plane
it 'requests landing clearance and location is airport after landing' do
expect(airport).to receive(:clear_for_landing)
subject.land airport
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use named subject?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@silvabox silvabox closed this Apr 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
QA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add challenge requirements clarity
4 participants
@tansaku @sjmog @dbugsy @silvabox