fix start_cursor request type (issue:#498)#510
Open
Sho-ki wants to merge 1 commit intomakenotion:mainfrom
Open
fix start_cursor request type (issue:#498)#510Sho-ki wants to merge 1 commit intomakenotion:mainfrom
Sho-ki wants to merge 1 commit intomakenotion:mainfrom
Conversation
|
I also noticed this inconsistency. UP! 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue on #498
Description
This PR resolves a type mismatch issue encountered when using the start_cursor in database.query.
The current implementation leads to a conflict between string | undefined and string | null in various scenarios involving the cursor.
Changes Made
Updated the type for start_cursor in QueryParameters to accept both null and undefined.
Expected Behavior:
With this change, you will no longer face typing issues when assigning next_cursor from a query response to a variable.