Add support for translations in actual addons #481
Conversation
robinborst95
force-pushed
the
feature/addon-paths
branch
3 times, most recently
from
bedf499 to
1531a58
Compare
robinborst95
force-pushed
the
feature/addon-paths
branch
from
1531a58 to
2ce9f10
Compare
robinborst95
force-pushed
the
feature/addon-paths
branch
from
2ce9f10 to
a1a139d
Compare
robinborst95
force-pushed
the
feature/addon-paths
branch
3 times, most recently
from
3304981 to
4f9e801
Compare
robinborst95
force-pushed
the
feature/addon-paths
branch
from
4f9e801 to
a307d87
Compare
robinborst95
force-pushed
the
feature/addon-paths
branch
from
a307d87 to
33cb043
Compare
There was a problem hiding this comment.
LGTM, i think the new opt in approach is best and it gives devs flexibility, Im still not a huge fan of using addon translations, but i think this works better then whitelisting the ones you are using as they can easily go out of date quickly. Thanks for your work and i'll look to create new release with your changes tomorrow
|
Thanks for the approval! I understand your thoughts about addon translations, so maybe good to quickly elaborate on how we use them. Our app consists of a few in-repo addons and a few actual addons, which are scoped dependencies, called So that's why we can safely rely on using some translations from these addons in our app, and it's the reason why I wanted to add support for it here :) While I'm at it, do you think this PR where I added support for the |
Similar to #480, but this PR adds support for actual addons, also issued in #5 (and closes #5). Not too sure if this covers all scenarios (I just looked up
translationsfolders innode_modules/*andnode_modules/@*/*, the latter for scoped addons), but at least it works for our codebase.To elaborate a bit: translations in actual addons are available for use in an app, but since they're not owned by the app, they show up under
Missing translations(the ones that are used). Just adding them to thetranslationFileswon't work properly yet, as that would cause such translations to end up underUnused translationswhile they could still be used by the addon itself (and that's not the purpose here). So, I split it up into own translations and addon translations, so that just the own translations can be used to detect unused translations, and the maps combined to detect missing translations.Note that I didn't add tests yet, I'd first like to have some confirmation that this a good approach.After I added a test for in-repo addons, it was quite simple to add a test for actual addons as well.