Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move hotkeys::{KeyBinding, Key, Modifier} into the config module #117

Open
oberien opened this issue Jul 21, 2017 · 2 comments
Open

Move hotkeys::{KeyBinding, Key, Modifier} into the config module #117

oberien opened this issue Jul 21, 2017 · 2 comments
Labels
driver technical-debt

Comments

@oberien
Copy link
Collaborator

oberien commented Jul 21, 2017

That way we can make hotkey non-pub.
@main--
Copy link
Owner

main-- commented Jul 21, 2017

(Postponed from #92.)

@main--
Copy link
Owner

main-- commented Jul 25, 2017

Wait WHAT?

No way! This is awful! The Keys enum has its own file for a reason! Moving it into the config module makes sense, but nothing else.

@oberien oberien changed the title Move hotkeys::{KeyBinding, Key, Modifier} into config.rs Move hotkeys::{KeyBinding, Key, Modifier} into the config module Jul 25, 2017
@oberien oberien added the driver label Aug 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
driver technical-debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@main-- @oberien