Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Add an option to disable the filling of wilderness/other claimed lands in the dynmap integration #99

Open
Cazok opened this issue Mar 28, 2021 · 0 comments

Comments

@Cazok
Copy link

Cazok commented Mar 28, 2021

Affected Plugin

  • Affected Plugin Name: Factions
  • Affected Plugin Version: 3.3.2

Describe your Environment

  • Server Version: git-Paper-"8b47131da" (MC: 1.16.5)

Current Situation

When the faction-dynmap integration is enabled, the dynmap incorrectly shows that chunks are claimed when a player claims the border of their faction but doesn't fill it in. The actual claims are only evident on the faction map/board, meaning that new players who often claim while looking at the dynmap and don't realize their claim isn't filled in.

Proposed Changes

Either try to rework the code for the integration that deals with filling chunks, or add a new section to the code that be enabled with a config option. The new section could theoretically just pull directly from the faction board/map to show the same claims as seen there.

Reasons for Changes

Showing factions as filled in when they are not can cause a LOT of issues, headaches, confusion, and delay. A great example of this filling in occured on SMPEarth when Technoblade claimed a rectangle around all continents on their earth map. That resulted in a lot of drama on their server, and the issue affects nearly every other server that uses the plugin, too. On the server I play on, this issue resulted in someone seemingly claiming a massive portion of land with their city in the middle, only to have it destroyed because they had claimed their border and done /f claim fill, which reached the max claim amount. Because it showed as filled in on the dynmap, and they had done /f claim fill, they assumed it was filled in. After their city was destroyed they not only blamed the owner of the server for having a "shitty plugin" (quoted from them), but also stopped donating to the server via the owner's Patreon. After that, they quit the server.

Not having an option to disable the filling of claims resulted in the owner losing a good amount of income, and a month or so later the server was shut down. I play on a similar server now, and I'm really worried that the same may happen to it and other servers unless something is changed. So, please at least strongly consider adding this request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant