\Magento\Quote\Model\Quote\Payment\ToOrderPayment Failure if payment has additionalData

[thomas-kl1]

Preconditions and environment

• Any version of Magento
• Anything else that would help a developer reproduce the bug

Steps to reproduce

• Add additionalInformation to the \Magento\Quote\Api\Data\PaymentInterface object in place order action
• When placing order, Magento copy quote payment to order payment
• \Magento\Quote\Model\Quote\Payment\ToOrderPayment::convert
• \Magento\Framework\DataObject\Copy::getDataFromFieldset
• This method is used:

case $source instanceof DataObject:
    $value = $source->getDataUsingMethod($code);
    break;

\Magento\Quote\Api\Data\PaymentInterface & \Magento\Sales\Api\Data\OrderPaymentInterface shares the same definition for additional property:

    /**
     * Get payment additional details
     *
     * @return string[]|null
     */
    public function getAdditionalData();

    /**
     * Set payment additional details
     *
     * @param string $additionalData
     * @return $this
     */
    public function setAdditionalData($additionalData);

Obviously, copying array to string will impact the save action of the order. When the order is saved, the payment relation is processed and throws an error of array to string conversion.

Expected result

Order is placed.

Actual result

An error occurred and the order is not placed.

Additional information

No response

Release note

No response

Triage and priority

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @thomas-kl1. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

• @magento give me 2.4-develop instance - upcoming 2.4.x release
• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this
• To learn more about issue processing workflow, refer to the Code Contributions.

---

Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[ia-gaurav]

@magento give me 2.4.6-develop instance

[magento-deployment-service]

Hi @ia-gaurav. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @ia-gaurav, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

[ia-gaurav]

@magento give me 2.4-develop instance

[magento-deployment-service]

Hi @ia-gaurav. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @ia-gaurav, here is your Magento Instance: https://e4112445b9a73c84cfcf69126c87795c.instances-prod.magento-community.engineering
Admin access: https://e4112445b9a73c84cfcf69126c87795c.instances-prod.magento-community.engineering/admin_84a8
Login: ca59fa83
Password: d1623b07d71e

[thomas-kl1]

@magento give me 2.4.6-develop instance

[magento-deployment-service]

Hi @thomas-kl1. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @thomas-kl1, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

[desaiuttam]

@magento give me 2.4.6-develop instance

[magento-deployment-service]

Hi @desaiuttam. Thank you for your request. I'm working on Magento instance for you.