Remove ExtendedDriverInterface from code

Author: vlmed

app/code/Magento/Eav/Model/Attribute/Data/Image.php

@@ -5,7 +5,7 @@
  */
 namespace Magento\Eav\Model\Attribute\Data;
 
-use Magento\Framework\Filesystem\ExtendedDriverInterface;
+use Magento\RemoteStorage\Driver\RemoteDriverInterface;
 
 /**
  * EAV Entity Attribute Image File Data Model
@@ -29,7 +29,7 @@ protected function _validateByRules($value)
     {
         $label = __($this->getAttribute()->getStoreLabel());
         $rules = $this->getAttribute()->getValidateRules();
-        $localStorage = !$this->_directory->getDriver() instanceof ExtendedDriverInterface;
+        $localStorage = !$this->_directory->getDriver() instanceof RemoteDriverInterface;
         $imageProp = $localStorage
             ? @getimagesize($value['tmp_name'])
             : $this->_directory->getDriver()->getMetadata($value['tmp_name']);

app/code/Magento/Eav/composer.json

@@ -11,7 +11,8 @@
         "magento/module-catalog": "*",
         "magento/module-config": "*",
         "magento/module-media-storage": "*",
-        "magento/module-store": "*"
+        "magento/module-store": "*",
+        "magento/module-remote-storage": "*"
     },
     "type": "magento2-module",
     "license": [

app/code/Magento/MediaGallerySynchronization/Model/CreateAssetFromFile.php

@@ -15,6 +15,7 @@
 use Magento\MediaGalleryApi\Api\Data\AssetInterfaceFactory;
 use Magento\MediaGallerySynchronization\Model\Filesystem\GetFileInfo;
 use Magento\MediaGallerySynchronizationApi\Model\CreateAssetFromFileInterface;
+use Magento\RemoteStorage\Driver\RemoteDriverInterface;
 
 /**
  * Create media asset object based on the file information
@@ -75,7 +76,7 @@ public function execute(string $path): AssetInterface
         $absolutePath = $this->getMediaDirectory()->getAbsolutePath($path);
         $driver = $this->getMediaDirectory()->getDriver();
 
-        if ($driver instanceof Filesystem\ExtendedDriverInterface) {
+        if ($driver instanceof RemoteDriverInterface) {
             $meta = $driver->getMetadata($absolutePath);
         } else {
             /**

app/code/Magento/MediaGallerySynchronization/composer.json

@@ -6,7 +6,8 @@
         "magento/framework": "*",
         "magento/module-media-gallery-api": "*",
         "magento/module-media-gallery-synchronization-api": "*",
-        "magento/framework-message-queue": "*"
+        "magento/framework-message-queue": "*",
+        "magento/module-remote-storage": "*"
     },
     "type": "magento2-module",
     "license": [

lib/internal/Magento/Framework/File/Mime.php

@@ -15,7 +15,7 @@
  * Utility for mime type retrieval
  *
  * @deprecated
- * @see Filesystem\ExtendedDriverInterface::getMetadata()
+ * @see Filesystem\DriverInterface::getMetadata()
  */
 class Mime
 {
@@ -113,12 +113,16 @@ public function getMimeType($file)
             throw new FileSystemException(__("File '$file' doesn't exist"));
         }
 
-        if ($driver instanceof Filesystem\ExtendedDriverInterface) {
-            return $driver->getMetadata($file)['mimetype'];
+        $mimeType = '';
+        if ($driver instanceof Filesystem\DriverInterface) {
+            $mimeType = $driver->getMetadata($file)['mimetype'];
         }
 
-        $mime = new Filesystem\Driver\File\Mime();
+        if (!$mimeType) {
+            $mime = new Filesystem\Driver\File\Mime();
+            $mimeType = $mime->getMimeType($file);
+        }
 
-        return $mime->getMimeType($file);
+        return $mimeType;
     }
 }

lib/internal/Magento/Framework/File/Test/Unit/MimeTest.php

@@ -56,7 +56,7 @@ class MimeTest extends TestCase
     protected function setUp(): void
     {
         $this->localDriverMock = $this->getMockForAbstractClass(Filesystem\DriverInterface::class);
-        $this->remoteDriverMock = $this->getMockForAbstractClass(Filesystem\ExtendedDriverInterface::class);
+        $this->remoteDriverMock = $this->getMockForAbstractClass(Filesystem\DriverInterface::class);
 
         $this->localDirectoryMock = $this->getMockForAbstractClass(Filesystem\Directory\WriteInterface::class);
         $this->localDirectoryMock->method('getDriver')

lib/internal/Magento/Framework/Filesystem/Driver/File.php

@@ -1144,7 +1144,7 @@ public function getMetadata(string $path): array
      *
      * @return bool
      */
-    private function isFileAnImage(string $mimeType): bool
+    protected function isFileAnImage(string $mimeType): bool
     {
         return strstr($mimeType, 'image/');
     }

lib/internal/Magento/Framework/Filesystem/Driver/Http.php

@@ -8,6 +8,7 @@
 
 namespace Magento\Framework\Filesystem\Driver;
 
+use League\Flysystem\AdapterInterface;
 use Magento\Framework\Exception\FileSystemException;
 
 /**
@@ -22,6 +23,11 @@ class Http extends File
      */
     protected $scheme = 'http';
 
+    /**
+     * @var AdapterInterface
+     */
+    private $adapter;
+
     /**
      * Checks if path exists
      *
@@ -228,6 +234,46 @@ public function getAbsolutePath($basePath, $path, $scheme = null)
         return $this->getScheme() . $basePath . $path;
     }
 
+    /**
+     * Retrieve file metadata.
+     *
+     * @param string $path
+     *
+     * @return array
+     * @throws FileSystemException
+     */
+    public function getMetadata(string $path): array
+    {
+        if (!$this->isExists($path)) {
+            throw new FileSystemException(__("File '$path' doesn't exist"));
+        }
+
+        $fileStat = $this->stat($path);
+        $mimeType = $fileStat['type'] ?? '';
+
+        $file = new \SplFileInfo($path);
+
+        if ($this->isFileAnImage($mimeType)) {
+            $imageInfo = getimagesize($this->getScheme() . $path);
+            $mimeType = $imageInfo['mime'] ?? $mimeType;
+        }
+
+        return [
+            'path' => $file->getPath(),
+            'dirname' => dirname($file->getPath()),
+            'basename' => $file->getBasename(),
+            'extension' => $file->getExtension(),
+            'filename' => $file->getFilename(),
+            'timestamp' => isset($fileStat['mtime']) ? strtotime($fileStat['mtime']) : 0,
+            'size' => $fileStat['size'] ?? 0,
+            'mimetype' => $mimeType,
+            'extra' => [
+                'image-width' => $imageInfo[0] ?? 0,
+                'image-height' => $imageInfo[1] ?? 0
+            ]
+        ];
+    }
+
     /**
      * Return path with scheme
      *