Skip to content

Commit e831030

Browse files
committed
AC-14557:: False positives in the backward-incompatible changes report (SVC)
1 parent 7eae21d commit e831030

File tree

4 files changed

+11
-14
lines changed

4 files changed

+11
-14
lines changed

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"laminas/laminas-stdlib": "^3.18",
1414
"nikic/php-parser": "^4.19",
1515
"phpstan/phpdoc-parser": "^0.5.5",
16-
"sabre/xml": "~4.0.6",
16+
"sabre/xml": "~4.0.5",
1717
"symfony/console": "~6.4.17",
1818
"symfony/string": "~6.4.15",
1919
"tomzx/php-semver-checker": "^0.16.0",

composer.lock

Lines changed: 8 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/Analyzer/ClassMethodAnalyzer.php

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -260,8 +260,7 @@ protected function reportChanged($report, $contextBefore, $contextAfter, $method
260260
$signatureChanged = true;
261261
} elseif ($signatureChanges['parameter_typing_changed']) {
262262

263-
if (
264-
$signatureChanges['parameter_nullable_type_added'] ||
263+
if ($signatureChanges['parameter_nullable_type_added'] ||
265264
$signatureChanges['parameter_nullable_type_removed']
266265
) {
267266
$data = new ClassMethodParameterTypingChangedNullable(
@@ -469,8 +468,7 @@ private function isReturnsEqualByNullability(ClassMethod $before, ClassMethod $a
469468
*/
470469
private function getDocReturnDeclaration(ClassMethod $method)
471470
{
472-
if (
473-
($parsedComment = $method->getAttribute('docCommentParsed'))
471+
if (($parsedComment = $method->getAttribute('docCommentParsed'))
474472
&& isset($parsedComment['return'])
475473
) {
476474
if ($parsedComment['return'][0] instanceof NullableType) {

src/Operation/ClassMethodParameterTypingChangedNullable.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ class ClassMethodParameterTypingChangedNullable extends ClassMethodOperationUnar
3636
'M119' => Level::MAJOR
3737
];
3838

39-
4039
/**
4140
* @var string
4241
*/

0 commit comments

Comments
 (0)