Skip to content

Commit dfabb3e

Browse files
committed
AC-6945::SVC false-positive build failures
1 parent eb2f14c commit dfabb3e

File tree

2 files changed

+15
-13
lines changed

2 files changed

+15
-13
lines changed

dev/tests/Unit/Console/Command/CompareSourceCommandDiXmlTest.php

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -83,41 +83,41 @@ public static function changesDataProvider()
8383
$pathToFixtures . '/moved-to-specific/source-code-before',
8484
$pathToFixtures . '/moved-to-specific/source-code-after',
8585
[
86-
'#Suggested semantic versioning change: PATCH#',
87-
'#PATCH\s*\|\s' . '[\w/]+' . '/moved-to-specific/source-code-before/Magento/TestModule/etc/di\.xml:0#',
86+
'#Suggested semantic versioning change: MAJOR#',
87+
'#MAJOR\s*\|\s' . '[\w/]+' . '/moved-to-specific/source-code-before/Magento/TestModule/etc/di\.xml:0#',
8888
'#scope\s*\|\s*Virtual Type was changed\s*\|\s*M201#'
8989
],
90-
'Patch change is detected.',
90+
'Major change is detected.',
9191
],
9292
'remove-type' => [
9393
$pathToFixtures . '/remove-type/source-code-before',
9494
$pathToFixtures . '/remove-type/source-code-after',
9595
[
96-
'#Suggested semantic versioning change: PATCH#',
97-
'#PATCH\s*\|\s' . '[\w/]+' . 'remove-type/source-code-before/Magento/TestModule/etc/di\.xml:0#',
96+
'#Suggested semantic versioning change: MAJOR#',
97+
'#MAJOR\s*\|\s' . '[\w/]+' . 'remove-type/source-code-before/Magento/TestModule/etc/di\.xml:0#',
9898
'#customCacheInstance2\s*\|\s*Virtual Type was removed\s*\|\s*M200\s*#'
9999
],
100-
'Patch change is detected.',
100+
'Major change is detected.',
101101
],
102102
'change-type' => [
103103
$pathToFixtures . '/change-type/source-code-before',
104104
$pathToFixtures . '/change-type/source-code-after',
105105
[
106-
'#Suggested semantic versioning change: PATCH#',
107-
'#PATCH\s*\|\s' . '[\w/]+' . '/change-type/source-code-before/Magento/TestModule/etc/di\.xml:0#',
106+
'#Suggested semantic versioning change: MAJOR#',
107+
'#MAJOR\s*\|\s' . '[\w/]+' . '/change-type/source-code-before/Magento/TestModule/etc/di\.xml:0#',
108108
'#type\s*\|\s*Virtual Type was changed\s*\|\s*M201#'
109109
],
110-
'Patch change is detected.',
110+
'Major change is detected.',
111111
],
112112
'change-name' => [
113113
$pathToFixtures . '/change-name/source-code-before',
114114
$pathToFixtures . '/change-name/source-code-after',
115115
[
116-
'#Suggested semantic versioning change: PATCH#',
117-
'#PATCH\s*\|\s*' . '[\w/]+' . '/change-name/source-code-before/Magento/TestModule/etc/di\.xml:0#',
116+
'#Suggested semantic versioning change: MAJOR#',
117+
'#MAJOR\s*\|\s*' . '[\w/]+' . '/change-name/source-code-before/Magento/TestModule/etc/di\.xml:0#',
118118
'#cacheInstance\s*\|\s*Virtual Type was removed\s*\|\s*M200#'
119119
],
120-
'Patch change is detected.',
120+
'Major change is detected.',
121121
],
122122
'removing-leading-slash-from-type' => [
123123
$pathToFixtures . '/removing-leading-slash-from-type/source-code-before',

dev/tests/Unit/Console/Command/HtmlTest.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ public static function changesDataProvider()
8181
['name' => 'test/api-trait', 'level' => 'MAJOR' ],
8282
['name' => 'test/layout_xml', 'level' => 'MAJOR' ],
8383
['name' => 'test/db_schema', 'level' => 'MAJOR' ],
84-
['name' => 'test/di_xml', 'level' => 'PATCH' ],
84+
['name' => 'test/di_xml', 'level' => 'MAJOR' ],
8585
['name' => 'test/system_xml', 'level' => 'MAJOR' ],
8686
['name' => 'test/xsd-schema', 'level' => 'MAJOR' ],
8787
['name' => 'test/less', 'level' => 'MAJOR' ],
@@ -103,6 +103,7 @@ public static function changesDataProvider()
103103
['name' => 'test/api-trait', 'level' => 'MAJOR' ],
104104
['name' => 'test/layout_xml', 'level' => 'MAJOR' ],
105105
['name' => 'test/db_schema', 'level' => 'MAJOR' ],
106+
['name' => 'test/di_xml', 'level' => 'MAJOR' ],
106107
['name' => 'test/system_xml', 'level' => 'MAJOR' ],
107108
['name' => 'test/xsd-schema', 'level' => 'MAJOR' ],
108109
['name' => 'test/less', 'level' => 'MAJOR' ],
@@ -124,6 +125,7 @@ public static function changesDataProvider()
124125
['name' => 'test/api-trait', 'level' => 'MAJOR' ],
125126
['name' => 'test/layout_xml', 'level' => 'MAJOR' ],
126127
['name' => 'test/db_schema', 'level' => 'MAJOR' ],
128+
['name' => 'test/di_xml', 'level' => 'MAJOR' ],
127129
['name' => 'test/system_xml', 'level' => 'MAJOR' ],
128130
['name' => 'test/xsd-schema', 'level' => 'MAJOR' ],
129131
['name' => 'test/less', 'level' => 'MAJOR' ],

0 commit comments

Comments
 (0)