AC-14557:: False positives in the backward-incompatible changes report (SVC)

Author: glo71317

composer.json

@@ -13,7 +13,7 @@
         "laminas/laminas-stdlib": "^3.18",
         "nikic/php-parser": "^4.19",
         "phpstan/phpdoc-parser": "^0.5.5",
-        "sabre/xml": "~4.0.5",
+        "sabre/xml": "~4.0.6",
         "symfony/console": "~6.4.17",
         "symfony/string": "~6.4.15",
         "tomzx/php-semver-checker": "^0.16.0",

composer.lock

@@ -41,6 +41,7 @@
 use PHPSemVerChecker\Operation\ClassMethodParameterTypingRemoved;
 use PHPSemVerChecker\Operation\ClassMethodRemoved;
 use PHPSemVerChecker\Report\Report;
+use Magento\SemanticVersionChecker\Operation\ClassMethodParameterTypingChangedNullable;
 
 /**
  * Class method analyzer.
@@ -258,12 +259,25 @@ protected function reportChanged($report, $contextBefore, $contextAfter, $method
                     $report->add($this->context, $data);
                     $signatureChanged = true;
                 } elseif ($signatureChanges['parameter_typing_changed']) {
-                    $data = new ClassMethodParameterTypingChanged(
-                        $this->context,
-                        $this->fileAfter,
-                        $contextAfter,
-                        $methodAfter
-                    );
+
+                    if (
+                        $signatureChanges['parameter_nullable_type_added'] ||
+                        $signatureChanges['parameter_nullable_type_removed']
+                    ) {
+                        $data = new ClassMethodParameterTypingChangedNullable(
+                            $this->context,
+                            $this->fileAfter,
+                            $contextAfter,
+                            $methodAfter
+                        );
+                    } else {
+                        $data = new ClassMethodParameterTypingChanged(
+                            $this->context,
+                            $this->fileAfter,
+                            $contextAfter,
+                            $methodAfter
+                        );
+                    }
                     $report->add($this->context, $data);
                     $signatureChanged = true;
                 }

src/Analyzer/ClassMethodAnalyzer.php

@@ -130,26 +130,39 @@ public static function analyze(array $parametersA, array $parametersB): array
         $changes = array_merge($changes, [
             'parameter_typing_added'          => false,
             'parameter_typing_removed'        => false,
-            'parameter_typing_changed'        => false
+            'parameter_typing_changed'        => false,
+            'parameter_nullable_type_added' => false,
+            'parameter_nullable_type_removed' => false,
+            'changed_param_index' => 0
         ]);
         $lengthA = count($parametersA);
         $lengthB = count($parametersB);
 
         $iterations = min($lengthA, $lengthB);
         for ($i = 0; $i < $iterations; ++$i) {
+
+            $typeBefore = $parametersA[$i]->type;
+            $typeAfter = $parametersB[$i]->type;
             // Re-implement type checking to handle type changes as a single operation instead of both add and remove
             if (Type::get($parametersA[$i]->type) !== Type::get($parametersB[$i]->type)) {
                 // This section changed from parent::analyze() to handle typing changes
                 if ($parametersA[$i]->type !== null && $parametersB[$i]->type !== null) {
                     $changes['parameter_typing_changed'] = true;
+                    // Custom: detect nullable added
+                    if ($typeBefore instanceof \PhpParser\Node\NullableType && !$typeAfter instanceof \PhpParser\Node\NullableType) {
+                        $changes['parameter_nullable_type_removed'] = true;
+                        $changes['changed_param_index'] = $i;
+                    } elseif (!$typeBefore instanceof \PhpParser\Node\NullableType && $typeAfter instanceof \PhpParser\Node\NullableType) {
+                        $changes['parameter_nullable_type_added'] = true;
+                        $changes['changed_param_index'] = $i;
+                    }
                 } elseif ($parametersA[$i]->type !== null) {
                     $changes['parameter_typing_removed'] = true;
                 } elseif ($parametersB[$i]->type !== null) {
                     $changes['parameter_typing_added'] = true;
                 }
             }
         }
-
         return $changes;
     }
 }

src/Comparator/Signature.php

@@ -0,0 +1,54 @@
+<?php
+
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+
+declare(strict_types=1);
+
+namespace Magento\SemanticVersionChecker\Operation;
+
+use PHPSemVerChecker\Operation\ClassMethodOperationUnary;
+use PHPSemVerChecker\SemanticVersioning\Level;
+
+class ClassMethodParameterTypingChangedNullable extends ClassMethodOperationUnary
+{
+    /**
+     * @var array
+     */
+    protected $code = [
+        'class'     => ['M113', 'M114', 'M115'],
+        'interface' => ['M116'],
+        'trait'     => ['M117', 'M118', 'M119']
+    ];
+
+    /**
+     * @var array
+     */
+    private $mapping = [
+        'M113' => Level::PATCH,
+        'M114' => Level::MAJOR,
+        'M115' => Level::PATCH,
+        'M116' => Level::MAJOR,
+        'M117' => Level::MAJOR,
+        'M118' => Level::MAJOR,
+        'M119' => Level::MAJOR
+    ];
+
+
+    /**
+     * @var string
+     */
+    protected $reason = 'Method parameter typing changed.';
+
+    /**
+     * Returns level of error.
+     *
+     * @return mixed
+     */
+    public function getLevel(): int
+    {
+        return $this->mapping[$this->getCode()];
+    }
+}