You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Pull request #14 (@rbrown) introduced support for CYMK images by converting them to RGB so that an image resize will not cause an image to become inverted in color. However, it doesn't work for sites using the Magento compiler, because the use of __DIR__ magic constant will point to [magento_root]/includes/src, instead of where the ICC profiles currently live [magento_root]/app/code/community/Varien/Image/Adapter/. The resulting resized image will still be inverted in color.
Suggestion to put the ICC files in [magento_root]/lib/FireGento/PerfectWatermarks/.
The text was updated successfully, but these errors were encountered:
I know many sites that are using the compiler, and many sites that don't. Just trying to make it compatible with everyone no matter what benefits the compiler may bring. Besides, /lib/ seems to be a more appropriate place to store external libraries.
Pull request #14 (@rbrown) introduced support for CYMK images by converting them to RGB so that an image resize will not cause an image to become inverted in color. However, it doesn't work for sites using the Magento compiler, because the use of
__DIR__
magic constant will point to[magento_root]/includes/src
, instead of where the ICC profiles currently live[magento_root]/app/code/community/Varien/Image/Adapter/
. The resulting resized image will still be inverted in color.Suggestion to put the ICC files in
[magento_root]/lib/FireGento/PerfectWatermarks/
.The text was updated successfully, but these errors were encountered: