Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sequenceProtoToMidi (no notes in output) #448

Open
jgoffin opened this issue May 7, 2020 · 4 comments
Open

sequenceProtoToMidi (no notes in output) #448

jgoffin opened this issue May 7, 2020 · 4 comments
Labels
bug Something isn't working core

Comments

@jgoffin
Copy link

jgoffin commented May 7, 2020

I'm using the drum kit rnn and am able to successfully produce samples. However, when I go to convert the note sequence object back into a MIDI file I get an empty output (no notes in the midi object). I've attached a simple example to demonstrate the issue I'm having.

This issue doesn't occur when I'm converting other note sequence objects back to MIDI files (say retrieve a midi file from bitmidi). This is the function that I'm relying on: https://magenta.github.io/magenta-js/music/modules/_core_midi_io_.html#sequenceprototomidi

Let me know if I can provide more detail!

seq_to_midi_issue.txt

@notwaldorf
Copy link
Collaborator

Could you console.log one of these note sequences that can't be converted to MIDI, please? I want to see if there's anything obvious with it (maybe it's empty, maybe it's missing a field, etc).

@notwaldorf
Copy link
Collaborator

Update: i've put the code in this https://jsbin.com/mopapow/edit?html,console,output, will take a look!

@notwaldorf
Copy link
Collaborator

I can't see anything at first glance. Some fields like timeSignatures seem empty, but I don't know if those are needed for the conversion. @iansimon does any of this look familiar?

@iansimon
Copy link
Collaborator

The issue seems to be that the notes have no velocity. If I manually set the velocities the conversion works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core
Projects
None yet
Development

No branches or pull requests

3 participants