Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddsp.spectral_ops.reset_crepe() should be documented #206

Open
turian opened this issue Sep 11, 2020 · 1 comment
Open

ddsp.spectral_ops.reset_crepe() should be documented #206

turian opened this issue Sep 11, 2020 · 1 comment

Comments

@turian
Copy link

turian commented Sep 11, 2020

In calling the model multiple times to create audio longer than 4 seconds, I ran into a GPU OOM issue caused by crepe.

ddsp.spectral_ops.reset_crepe() is used in the notebooks, but is not really documented.

It turns out that if you call ddsp.spectral_ops.reset_crepe() repeatedly (once before every model call) that leaks memory. This method should only be called once.

PROPOSED RESOLUTION:

Add code comment to ddsp.spectral_ops.reset_crepe() describing that it should only be called once per session AND that it leaks memory if called repeatedly (instead of just freeing its memory). Each time a colab uses this command, also document there this peculiarity.

Lastly, but not required, it would be very helpful that the timbe transfer colab actually works on the full audio file, instead of 4 seconds.

@turian
Copy link
Author

turian commented Sep 11, 2020

What also should be described is, if I load a new DDSP model, do I need to re-initialize crepe or not?
It would also just be great to fix the underlying leak so repeatedly calling crepe wouldn't be so fraught with peril

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant