Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images: add support to download set/rarity svg icons from scryfall or remove it at all? #13261

Open
JayDi85 opened this issue Jan 26, 2025 · 0 comments
Assignees
Labels
Developers Discussion Discussion about redesign or changes download GUI refactoring Developers topics about code and programming

Comments

@JayDi85
Copy link
Member

JayDi85 commented Jan 26, 2025

Image

Set's icons (rarity icons) used in very limited placed by xmage:

  • card viewer (if icon available);
  • m15 render mode (if icon available);
  • popup text mode (if icon available);

Current version uses gatherer source for set's icons download. It's low quality and outdated (without sets from last few years);

Scryfall can be used as high quality source of that icons (like mana icons). It's require to do:

  • implement set's svg icons download from scryfall (in symbols download pipeline, simple scryfall api from set's endpoint);
  • implement set's icons generations by color (scryfall icons are black and white but xmage require rarity colors);

Set's icons are useless now, but in the future it may be used by some potential app's features (decks, drafts or collection related features for better GUI or information).

I prefer to delete set icons at all and replace it by rarity chars like C,U,R,M,S (deck editor already use same logic). It will simplify code support and improve user experience in download tasks (current version generate too much errors and other logs while symbols download).

But it open for any potential ideas about that icons usage.

@JayDi85 JayDi85 added Developers Discussion Discussion about redesign or changes download refactoring Developers topics about code and programming labels Jan 26, 2025
@JayDi85 JayDi85 self-assigned this Jan 26, 2025
@JayDi85 JayDi85 changed the title Images: add support to download set's svg icons from scryfall or remove it at all? Images: add support to download set/rarity svg icons from scryfall or remove it at all? Jan 26, 2025
@JayDi85 JayDi85 added the GUI label Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Developers Discussion Discussion about redesign or changes download GUI refactoring Developers topics about code and programming
Projects
None yet
Development

No branches or pull requests

1 participant