Merge pull request #666 from ivanhrytsaim/13057-Improve-error-displaying-in-the-Blog-Api

13057-Improve-error-displaying-in-the-Blog-Api

Author: magefan

Model/AbstractManagement.php

@@ -100,7 +100,7 @@ public function create($data)
             $item->setData($data)->save();
             return json_encode($item->getData());
         } catch (\Exception $e) {
-            return false;
+            return $this->getError($e->getMessage());
         }
     }
 
@@ -118,7 +118,7 @@ public function update($id, $data)
             $item->load($id);
 
             if (!$item->getId()) {
-                return false;
+                return $this->getError('Item not found');
             }
             $data = json_decode($data, true);
             foreach ($this->_imagesMap as $key) {
@@ -133,7 +133,7 @@ public function update($id, $data)
             $item->addData($data)->save();
             return json_encode($item->getData());
         } catch (\Exception $e) {
-            return false;
+            return $this->getError($e->getMessage());
         }
     }
 
@@ -152,9 +152,9 @@ public function delete($id)
                 $item->delete();
                 return true;
             }
-            return false;
+            return $this->getError('Something went wrong');
         } catch (\Exception $e) {
-            return false;
+            return $this->getError($e->getMessage());
         }
     }
 
@@ -171,11 +171,11 @@ public function get($id)
             $item->load($id);
 
             if (!$item->getId()) {
-                return false;
+                return $this->getError('Item not found');
             }
             return json_encode($item->getData());
         } catch (\Exception $e) {
-            return false;
+            return $this->getError($e->getMessage());
         }
     }
 
@@ -193,12 +193,12 @@ public function view($id, $storeId)
             $item->getResource()->load($item, $id);
 
             if (!$item->isVisibleOnStore($storeId)) {
-                return false;
+                return $this->getError('Item is not visible on this store.');
             }
 
             return json_encode($this->getDynamicData($item));
         } catch (\Exception $e) {
-            return false;
+            return $this->getError($e->getMessage());
         }
     }
 
@@ -207,4 +207,16 @@ public function view($id, $storeId)
      * @return mixed
      */
     abstract protected function getDynamicData($item);
+
+    /**
+     * @param $massage
+     * @return false|string
+     */
+    public function getError($massage) {
+        $data = ['error' => 'true'];
+        
+        $data['message'] = $massage ?? '';
+
+        return json_encode($data);
+    }
 }

Model/CategoryManagement.php

@@ -71,7 +71,7 @@ public function getList($type, $term, $storeId, $page, $limit)
 
             return json_encode($result);
         } catch (\Exception $e) {
-            return false;
+            return $this->getError($e->getMessage());
         }
     }
 

Model/CommentManagement.php

@@ -73,7 +73,7 @@ public function getList($type, $term, $storeId, $page, $limit)
 
             return json_encode($result);
         } catch (\Exception $e) {
-            return false;
+            return $this->getError($e->getMessage());
         }
     }
 

Model/PostManagement.php

@@ -101,7 +101,7 @@ public function getList($type, $term, $storeId, $page, $limit)
 
             return json_encode($result);
         } catch (\Exception $e) {
-            return false;
+            return $this->getError($e->getMessage());
         }
     }
 

Model/TagManagement.php

@@ -73,7 +73,7 @@ public function getList($type, $term, $storeId, $page, $limit)
 
             return json_encode($result);
         } catch (\Exception $e) {
-            return false;
+            return $this->getError($e->getMessage());
         }
     }