Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge rust-bitcoin#2940: Revert "bug fix" (actually a bug) from rust-…
…bitcoin#2655 7f024c3 Revert "bug fix" (actually a bug) from rust-bitcoin#2655 (Martin Habovstiak) Pull request description: In a2b019f it was claimed that losing the input string without alloc is a bug. It is not, because allowing no-alloc is desired and there's no way to have the input string otherwise so we just accept it'll be missing and modify the messages accordingly. The commit that forced alloc was also horribly misleading since it kept the `alloc` feature but it makes this one easier. Note that input string is still present by default in all configurations except for no-alloc. I think we should also backport this and release fixed `units` because of the misleading `alloc` feature in them. Although it's not urgent. The only crate I know of that is kinda broken by it is `ln_types` which is already broken by depending on old `bitcoin`. ACKs for top commit: apoelstra: ACK 7f024c3 tcharding: ACK 7f024c3 Tree-SHA512: 014ed823f0daf2c47ca6cedf1aad0d94b702f2ca53b096556a76566baeadb209b9d4d710872c2b8308542fd7cfe6d815a206f1a84174458d251bf30882be7719
- Loading branch information