Skip to content

Commit e08c356

Browse files
macvincentfacebook-github-bot
authored andcommitted
Refactor Velox Writer to Use New Flush Policy Contract (facebookincubator#242)
Summary: This should be a no-op since no chunking flush policy is currently being used in Prod. but we make three changes in this dif: 1. `writeChunk` now returns a boolean to indicate whether any stream was successfully chunked 2. The previous raw size of the encoded stripe data in the writer context is now stored in the Writer context 3. We update and pass down the memory stats needed by the new flush policy contract TODO: We will be introducing two more VeloxWriter changes in the next diffs in this stack to: 1. Support per stream chunking instead of always chunking all eligible streams 2. Support breaking down large stream into multiple smaller chunks Reviewed By: helfman Differential Revision: D81545433
1 parent 02c6f98 commit e08c356

File tree

4 files changed

+547
-100
lines changed

4 files changed

+547
-100
lines changed

dwio/nimble/common/MetricsLogger.h

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,9 +74,10 @@ struct FileCloseMetrics {
7474
};
7575

7676
enum class LogOperation {
77+
Write,
78+
Flush,
79+
Close,
7780
StripeLoad,
78-
StripeFlush,
79-
FileClose,
8081
CompressionContext,
8182
};
8283

0 commit comments

Comments
 (0)