Consider removing ViewModelRendering

[krris]

Consider removing ViewModelRendering.

[ochococo]

@krris What do you mean?

[krris]

Currently ViewModelRendering is only used by two widgets: WatchWidgetView and ImageWidgetView. All other widgets don't use it. We should think if this protocol is still needed. It's worth noting that in README it's said:

View: a view implementing ViewModelRendering protocol that displays the information.

but only two of our widgets follow the guidelines.

[ochococo]

So there are two Widgets using it.
Why the rest doesn't? I don't know. Ask the authors.

This protocol is here to stay, not sure about those Widgets (they come and go as you know).

[ochococo]

We could talk about it and maybe introduce another method configureWithViewModel: and mark the old ones as deprecated?

[ochococo]

But with this response latency @krris it will be really hard to discuss 😀

[ochococo]

WDYT @michallaskowski ?

[krris]

Sorry for late response but I missed notifications. So let's leave as it is. Also I would prefer to do as you say:

introduce another method configureWithViewModel: and mark the old ones as deprecated

Maybe we should refactor other widgets a little to follow the guidelines?

[michallaskowski]

It is not the problem with widgets not using it, because Core is not using it. Then there is no point in having this protocol.

I am in for removing it, since it has no effect. Because widgets are responsible for creating views, we should not force MVVM on them. Current protocol for 'WidgetControlling' is enough for me.

[ochococo]

@krris We can refactor but one thing should be clear: there is noting like "ErrorWidget" or "ErrorMode" - not every Widget should have "erroneous mode" and something like blank error view on Clock widget is a big mistake.

@michallaskowski I would like to "guide" the developer not to enforce (as there is no constraint, just a convention).