Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

machine.py tools vs tool attribute distinction #6

Open
brendenpelkie opened this issue Oct 10, 2023 · 1 comment
Open

machine.py tools vs tool attribute distinction #6

brendenpelkie opened this issue Oct 10, 2023 · 1 comment
Labels
enhancement Improvements for an existing feature

Comments

@brendenpelkie
Copy link
Collaborator

the Machine object has both a 'tool' (the current tool) attribute as well as 'tools' (the list of available tools). The distinction between these should be made more clear by renaming one.
@bsubbaraman bsubbaraman added the enhancement Improvements for an existing feature label Oct 11, 2023
@bsubbaraman
Copy link
Member

bsubbaraman commented Oct 11, 2023 •
edited
Loading

Good point (and there's also configured_tools which is reads from the RRF object model!). I propose changing tools to loaded_tools since this information is updated after a load_tool() command. Maybe it's worth also renaming tool to active_tool to be explicit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improvements for an existing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bsubbaraman @brendenpelkie