Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

picamera required dependeny #38

Open
brendenpelkie opened this issue Dec 4, 2023 · 4 comments
Open

picamera required dependeny #38

brendenpelkie opened this issue Dec 4, 2023 · 4 comments
Assignees

Comments

@brendenpelkie
Copy link
Collaborator

The picamera package is listed as a dependency in setup.py, making science_jubilee uninstallable on a non-pi system (or at least my WSL ubuntu instance).

Proposed fix:

  1. remove picamera from base install dependencies
  2. add steps to check install/manage install of picamera to camera tools that directly run on a pi
@bsubbaraman
Copy link
Member

Good catch-- currently it installs fine on mac or windows, but the conditional check in setup.py is currently if running on linux; I would propose changing this to check the os_name to only install on Raspberry Pi!

@brendenpelkie
Copy link
Collaborator Author

That makes sense too. That's cool I didn't know you could do conditional installs like that!

@brendenpelkie
Copy link
Collaborator Author

Addressed by #41. Checks for pi camera by checking for aarch64 machine instead of linux platform.

@bsubbaraman
Copy link
Member

Reopening because I just tried a fresh install on my pi 3 which isn't aarch64 so picamera doesn't install! I'll submit a pull request with a fix for this one

@bsubbaraman bsubbaraman reopened this Feb 27, 2024
@bsubbaraman bsubbaraman self-assigned this Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants