Chore: add specs for Pyinstaller build, and change AUR PKGBUILD to use Pyinstaller for build#48
Draft
ponleou wants to merge 4 commits into
Draft
Chore: add specs for Pyinstaller build, and change AUR PKGBUILD to use Pyinstaller for build#48ponleou wants to merge 4 commits into
ponleou wants to merge 4 commits into
Conversation
Contributor
Author
|
Thought I'd make the PR anyways because it might help the macOS side of things. |
Contributor
Author
|
Actually, some more work can still be done, specifically the PKGBUILD dependencies. Because Pyinstaller bundles a lot of them, I think most of them could be removed, but I need to test it on a clean device,. Not entirely sure which one can be omitted, but I'd assume all |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #44
Also includes a fix for AUR packaging to use the app icon instead of the temporary navigation icon.
Apart from the specs file for Pyinstaller, I also modified the current AUR PKGBUILD itself. If this is unwanted, feel free to revert it, perhaps I could maintain a different aur package using pyinstaller build. Everything seems to work the same on my machine, but please do help test.
Also modified main.py to fallback to using the built directory for Pyinstaller support. Minimal change and should not impact normal application.